[GitHub] [geode] PurelyApplied opened pull request #2569: GEODE-5804: Improve checkPom task

["PurelyApplied (GitHub)" <gi...@apache.org>]

* Add `updateExpectedPom` task to perform copy of actual to expected.
----

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #2569: GEODE-5804: Improve checkPom task

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Why does the expected file need to exist in order to update/place. We could use this task to generate the baseline for a newly-minted module.

[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot closed pull request #2569: GEODE-5804: Improve checkPom task

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

[ pull request closed by rhoughton-pivot ]

[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task

["PurelyApplied (GitHub)" <gi...@apache.org>]

It seems like the actual `checkPom` task is only examining `<dependency>` blocks and not any other data.  So, on the one hand, the existing behavior was "copy the actual pom to the expected pom" is what's happening, but a developer will then need to examine which difference should actually be added to their commit.

So that's strange and we should decide if `checkPom` should also be checking, for instance, the `<packaging>` for consistency.  Or decide that what goes into a diff is just developer responsibility.

[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2569: GEODE-5804: Improve checkPom task

["PurelyApplied (GitHub)" <gi...@apache.org>]

I had been poking at it to make sure it's still good.  I was getting some strange behavior where `./gradlew uEP` updates the assembly pom with
```
diff --git a/geode-assembly/src/test/resources/expected-pom.xml b/geode-assembly/src/test/resources/expected-pom.xml
index 3f8abf5e57..b22bc8f393 100644
--- a/geode-assembly/src/test/resources/expected-pom.xml
+++ b/geode-assembly/src/test/resources/expected-pom.xml
@@ -20,7 +20,7 @@
   <groupId>org.apache.geode</groupId>
   <artifactId>apache-geode</artifactId>
   <version>1.8.0-SNAPSHOT</version>
-  <packaging>pom</packaging>
+  <packaging>tgz</packaging>
   <name>Apache Geode</name>
   <description>Apache Geode provides a database-like consistency model, reliable transaction processing and a shared-nothing architecture to maintain very low latency performance with high concurrency processing</description>
   <url>http://geode.apache.org</url>

```

It had been the dependency block I'd messed with to make sure I hadn't broken `checkPom`, so I don't know if there is just some dirty artifact there.  Need to play with it a little more.

[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #2569: GEODE-5804: Improve checkPom task

["PurelyApplied (GitHub)" <gi...@apache.org>]

I suppose it doesn't! 

[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org