You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/04 08:24:02 UTC
[GitHub] [spark] sungpeo opened a new pull request #35094: [SPARK-20624] rearranged logging in decommission loop
sungpeo opened a new pull request #35094:
URL: https://github.com/apache/spark/pull/35094
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Lower logging level, and transferred logInfo in a loop to outside
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
[SPARK-36543] Decommission logs too frequent when waiting migration to finish
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
It doesn't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo commented on pull request #35094: [SPARK-20624] rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1004609260
@holdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo commented on pull request #35094: [SPARK-36543][CORE] Rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1006288607
@dongjoon-hyun
`logInfo` for other cases in the loop remain.
I think those (the remain logInfo) are enough to track the decommission.
Below logInfo(s) were repeated every loop for waiting done.
I agree with that was too much.
- https://issues.apache.org/jira/browse/SPARK-36543
```scala
...
logInfo("Checking to see if we can shutdown.")
...
logInfo("No running tasks, checking migrations")
...
logInfo("All blocks not yet migrated.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo edited a comment on pull request #35094: [SPARK-36543][CORE] Rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
sungpeo edited a comment on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1005289565
@HyukjinKwon
Thank you for letting me know.
I enabled Github actions again, and sync (rebase) my branch to the latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo edited a comment on pull request #35094: [SPARK-20624] rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
sungpeo edited a comment on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1004609260
@holdenk
Made it simply logging less.
I changed `logInfo` without changing states to `logDebug`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo commented on pull request #35094: [SPARK-36543][CORE] Rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1005289565
@HyukjinKwon
Thank you for letting me know.
I enabled Github actions again, and sync my branch to the latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35094: [SPARK-36543][CORE] Rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1004693567
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35094: [SPARK-36543][CORE] Rearranged logging in decommission loop
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35094:
URL: https://github.com/apache/spark/pull/35094#issuecomment-1004630680
@sungpeo BTW, Apache Spark repository leverages the resources from GItHub Actions in your forked repository for your PR so it should be enabled in your forked repository to run the tests, see also https://github.com/apache/spark/pull/35094/checks?check_run_id=4699635992.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org