You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/27 21:38:50 UTC
[GitHub] jihoonson commented on issue #5980: Remove redundant type
parameters and enforce some other style and inspection rules
jihoonson commented on issue #5980: Remove redundant type parameters and enforce some other style and inspection rules
URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-408545206
Thanks @asdf2014! The latest change looks good to me.
One side comment: usually, you can expect your PR can be reviewed faster as your PR contains less changes because it's much easier to review. It would be great if you can split your PRs if possible in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org