You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/28 00:56:53 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #754: ORC-852: Allow DynamicByteArray to return a ByteBuffer

dongjoon-hyun commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r697780280



##########
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##########
@@ -46,6 +47,18 @@ public static void getTextInternal(Text result, int position,
     byteArray.setText(result, offset, length);
   }
 
+  public static ByteBuffer getTextInternal(int position, DynamicIntArray keyOffsets,

Review comment:
       Could you add a function description please, @belugabehr ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org