You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2024/02/20 23:08:54 UTC
[PR] Deprecate PY* constants into the airflow module [airflow]
Taragolis opened a new pull request, #37575:
URL: https://github.com/apache/airflow/pull/37575
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
First constant was added in https://github.com/apache/airflow/pull/7517 for validate is Airflow run on Python >= 3.7 and if not use backport support of [PEP-562](https://peps.python.org/pep-0562/).
It is not widely use in Airflow Core, at that moment there is only one reference. However it might be not safe to use it in core, because it might create cyclic error in case if it imported somewhere else during first load, e.g. into the `airflow.configurations` or `airflow.settings` or their imports. In providers it is not practical to use it, you have to wait approx one year for allow to use it, and it also might be a reason for cyclic errors, e.g. if it use in secrets backends and their imports.
For avoid usage in project it disabled by `TID251` - Banned API
All current usage, most in tests, replaced by sys.version_info
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497218249
##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
import pytest
from dateutil.tz import tzutc
from deltalake import DeltaTable
+from packaging.version import Version
from pendulum import DateTime
from pendulum.tz.timezone import FixedTimezone, Timezone
-from airflow import PY39
from airflow.models.param import Param, ParamsDict
from airflow.serialization.serde import DATA, deserialize, serialize
-if PY39:
+if sys.version_info >= (3, 9):
Review Comment:
The API of importlib.metadata not fully compatible between provisional (3.8-3.9) an stable (3.10+)
I think maybe it should be compatible in versions, since we use it in 3.9 which also provisional.
My thoughts that we should use bakported version, just not for thinking about is this functional compatible or not.
But since this part about the tests we might use only stdlib version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497485603
##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
import pytest
from dateutil.tz import tzutc
from deltalake import DeltaTable
+from packaging.version import Version
from pendulum import DateTime
from pendulum.tz.timezone import FixedTimezone, Timezone
-from airflow import PY39
from airflow.models.param import Param, ParamsDict
from airflow.serialization.serde import DATA, deserialize, serialize
-if PY39:
+if sys.version_info >= (3, 9):
Review Comment:
> But since this part about the tests we might use only stdlib version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1496672314
##########
tests/providers/apache/hive/hooks/test_hive.py:
##########
@@ -17,22 +17,13 @@
# under the License.
from __future__ import annotations
-import pytest
-
-from airflow import PY311
-
-if PY311:
- pytest.skip(
- "The tests are skipped because Apache Hive provider is not supported on Python 3.11",
- allow_module_level=True,
- )
-
Review Comment:
Seems like it should be resolved in https://github.com/apache/airflow/pull/32607
But lets have a look on tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1496676280
##########
tests/providers/apache/hive/hooks/test_hive.py:
##########
@@ -17,22 +17,13 @@
# under the License.
from __future__ import annotations
-import pytest
-
-from airflow import PY311
-
-if PY311:
- pytest.skip(
- "The tests are skipped because Apache Hive provider is not supported on Python 3.11",
- allow_module_level=True,
- )
-
Review Comment:
When I check is pyhive supported Python 3.12, I've found that project doesn't supported anymore:
- https://github.com/dropbox/PyHive
- https://pypi.org/project/PyHive/
But this titles added two years ago by https://github.com/dropbox/PyHive/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1496687314
##########
airflow/__init__.py:
##########
@@ -91,6 +84,16 @@ def __getattr__(name: str):
# PEP-562: Lazy loaded attributes on python modules
module_path, attr_name, deprecated = __lazy_imports.get(name, ("", "", False))
if not module_path:
+ if name.startswith("PY3") and (py_minor := name[3:]) in ("6", "7", "8", "9", "10", "11", "12"):
+ import warnings
+
+ warnings.warn(
+ f"Python version constraint {name!r} is deprecated and will be removed in the future. "
+ f"Please get version info from the 'sys.version_info'.",
+ DeprecationWarning,
+ )
+ return sys.version_info >= (3, int(py_minor))
Review Comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497308622
##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
import pytest
from dateutil.tz import tzutc
from deltalake import DeltaTable
+from packaging.version import Version
from pendulum import DateTime
from pendulum.tz.timezone import FixedTimezone, Timezone
-from airflow import PY39
from airflow.models.param import Param, ParamsDict
from airflow.serialization.serde import DATA, deserialize, serialize
-if PY39:
+if sys.version_info >= (3, 9):
Review Comment:
On the one hand, we're not using whichever part of the API of `importlib.metadata` that changed when transitioning from provisional to stable (so in that sense, provisional is fine) here. On the other hand, as you mentioned, 3.9 is also still provisional, so there's no specific reason for checking for _that_.
So yeah, I prefer this check gone, but if you feel it's needed, I think you should check for 3.10 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #37575:
URL: https://github.com/apache/airflow/pull/37575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497145333
##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
import pytest
from dateutil.tz import tzutc
from deltalake import DeltaTable
+from packaging.version import Version
from pendulum import DateTime
from pendulum.tz.timezone import FixedTimezone, Timezone
-from airflow import PY39
from airflow.models.param import Param, ParamsDict
from airflow.serialization.serde import DATA, deserialize, serialize
-if PY39:
+if sys.version_info >= (3, 9):
Review Comment:
The python version check is unnecessary for `importlib.metadata`. I know this because my own changes, that don't include this guard, passed the tests (that ran among else on py 3.8, as far as I can tell) and got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1498172066
##########
tests/providers/apache/hive/hooks/test_hive.py:
##########
@@ -17,22 +17,13 @@
# under the License.
from __future__ import annotations
-import pytest
-
-from airflow import PY311
-
-if PY311:
- pytest.skip(
- "The tests are skipped because Apache Hive provider is not supported on Python 3.11",
- allow_module_level=True,
- )
-
Review Comment:
Yes. It stopped being supported, but it **should** work since we use pure_python_sasl implementation. Some day we might want to remove it I guess. Not sure when :D. Maybe when hive is moved to attic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #37575:
URL: https://github.com/apache/airflow/pull/37575#issuecomment-1955290776
I do not delete this constants for two reason:
- Maybe some old version of provider still use it
- Maybe some users use it, which is not practical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate PY* constants into the airflow module [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #37575:
URL: https://github.com/apache/airflow/pull/37575#discussion_r1497145333
##########
tests/serialization/serializers/test_serializers.py:
##########
@@ -26,19 +27,22 @@
import pytest
from dateutil.tz import tzutc
from deltalake import DeltaTable
+from packaging.version import Version
from pendulum import DateTime
from pendulum.tz.timezone import FixedTimezone, Timezone
-from airflow import PY39
from airflow.models.param import Param, ParamsDict
from airflow.serialization.serde import DATA, deserialize, serialize
-if PY39:
+if sys.version_info >= (3, 9):
Review Comment:
The python version check is unnecessary. I know this because my own changes, that don't include this guard, passed the tests (that ran on py 3.8 as far as I can tell) and got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org