You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by "Jim Ancona (JIRA)" <ji...@apache.org> on 2008/01/29 22:10:35 UTC
[jira] Created: (ABDERA-92) Spring DefaultProviderDefinitionParser
doesn't support adding Filters
Spring DefaultProviderDefinitionParser doesn't support adding Filters
---------------------------------------------------------------------
Key: ABDERA-92
URL: https://issues.apache.org/jira/browse/ABDERA-92
Project: Abdera
Issue Type: Bug
Affects Versions: 0.4.0
Reporter: Jim Ancona
Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ABDERA-92) Spring DefaultProviderDefinitionParser
doesn't support adding Filters
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James M Snell resolved ABDERA-92.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
Committed. One thing you may want to think about: some filters may have configuration parameters that need to be set (e.g. the OpenSearchFilter I used in the tests and example). We may need to introduce some kind of FilterConfig mechanism so these properties can be set.
> Spring DefaultProviderDefinitionParser doesn't support adding Filters
> ---------------------------------------------------------------------
>
> Key: ABDERA-92
> URL: https://issues.apache.org/jira/browse/ABDERA-92
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Fix For: 0.4.0
>
> Attachments: SpringParser.patch, SpringParser2.patch
>
>
> Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-92) Spring
DefaultProviderDefinitionParser doesn't support adding Filters
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566223#action_12566223 ]
James M Snell commented on ABDERA-92:
-------------------------------------
Hmm.. the patch does not seem to quite match up with the current code in the spring module. I don't have the time at the moment to sync these up and I don't really know enough about spring to do it anyway. It would be helpful if you could check the patch against the current code, make any necessary changes, then update it here.
> Spring DefaultProviderDefinitionParser doesn't support adding Filters
> ---------------------------------------------------------------------
>
> Key: ABDERA-92
> URL: https://issues.apache.org/jira/browse/ABDERA-92
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Attachments: SpringParser.patch
>
>
> Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-92) Spring DefaultProviderDefinitionParser
doesn't support adding Filters
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated ABDERA-92:
-----------------------------
Attachment: SpringParser.patch
Modifies the parser to take an <a:filter> element.
Also fixes the problem where the <a:workspace> element parser didn't properly handle <ref> elements.
Unit test update included.
> Spring DefaultProviderDefinitionParser doesn't support adding Filters
> ---------------------------------------------------------------------
>
> Key: ABDERA-92
> URL: https://issues.apache.org/jira/browse/ABDERA-92
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Attachments: SpringParser.patch
>
>
> Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-92) Spring
DefaultProviderDefinitionParser doesn't support adding Filters
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566320#action_12566320 ]
Jim Ancona commented on ABDERA-92:
----------------------------------
Since the <a:filter/> element uses a standard Spring <bean/> element to specify the implementation, configuration could be handled using Spring's standard DI mechanisms. It might be possible to add some more syntax sugar in the XML, but I'm beyond my depth in the Spring 2 parsing APIs with what I've already done, so I'll defer to Dan.
> Spring DefaultProviderDefinitionParser doesn't support adding Filters
> ---------------------------------------------------------------------
>
> Key: ABDERA-92
> URL: https://issues.apache.org/jira/browse/ABDERA-92
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Fix For: 0.4.0
>
> Attachments: SpringParser.patch, SpringParser2.patch
>
>
> Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-92) Spring DefaultProviderDefinitionParser
doesn't support adding Filters
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated ABDERA-92:
-----------------------------
Attachment: SpringParser2.patch
I believe Dan did a commit along the way that I had to merge. Here is what I have currently.
> Spring DefaultProviderDefinitionParser doesn't support adding Filters
> ---------------------------------------------------------------------
>
> Key: ABDERA-92
> URL: https://issues.apache.org/jira/browse/ABDERA-92
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Attachments: SpringParser.patch, SpringParser2.patch
>
>
> Patch to follow
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.