You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/02/21 06:58:05 UTC
[GitHub] [spark] wangyum opened a new pull request, #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
wangyum opened a new pull request, #40100:
URL: https://github.com/apache/spark/pull/40100
### What changes were proposed in this pull request?
Fix `Sort`'s maxRowsPerPartition if maxRows does not exist.
### Why are the changes needed?
`LimitPushDown` may be use this value.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #40100:
URL: https://github.com/apache/spark/pull/40100#issuecomment-1437946552
cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #40100:
URL: https://github.com/apache/spark/pull/40100#issuecomment-1438028048
Thank you @zhengruifeng, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
URL: https://github.com/apache/spark/pull/40100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40100: [SPARK-42506][SQL] Fix Sort's maxRowsPerPartition if maxRows does not exist
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40100:
URL: https://github.com/apache/spark/pull/40100#issuecomment-1437975144
I'm not sure whether we can use `child.maxRowsPerPartition` in a global sort, for example, the partition sizes maybe [5, 5, 5] in child, but after global sort the distribution maybe [3, 3, 3, 3, 3]
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org