You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/10/30 03:28:42 UTC

Review Request 27370: Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27370/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-8034
    https://issues.apache.org/jira/browse/AMBARI-8034


Repository: ambari


Description
-------

Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands.
The slider scripts need to handle this condition.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/slider.py 9944865 

Diff: https://reviews.apache.org/r/27370/diff/


Testing
-------

Ran unit tests on ambari-server, and reproduced and fixed on a live cluster.


Thanks,

Alejandro Fernandez


Re: Review Request 27370: Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27370/#review59118
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Oct. 30, 2014, 2:29 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27370/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:29 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8034
>     https://issues.apache.org/jira/browse/AMBARI-8034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands.
> The slider scripts need to handle this condition.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/slider.py 9944865 
> 
> Diff: https://reviews.apache.org/r/27370/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests on ambari-server, and reproduced and fixed on a live cluster.
> 
> ----------------------------------------------------------------------
> Total run:679
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 27370: Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27370/#review59117
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Oct. 30, 2014, 2:29 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27370/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 2:29 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-8034
>     https://issues.apache.org/jira/browse/AMBARI-8034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands.
> The slider scripts need to handle this condition.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/slider.py 9944865 
> 
> Diff: https://reviews.apache.org/r/27370/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests on ambari-server, and reproduced and fixed on a live cluster.
> 
> ----------------------------------------------------------------------
> Total run:679
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Re: Review Request 27370: Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27370/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 2:29 a.m.)


Review request for Ambari, Jaimin Jetly, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-8034
    https://issues.apache.org/jira/browse/AMBARI-8034


Repository: ambari


Description
-------

Slider configuration for slider-client could be empty and hence not set in the supplied configuration to install commands.
The slider scripts need to handle this condition.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/slider.py 9944865 

Diff: https://reviews.apache.org/r/27370/diff/


Testing (updated)
-------

Ran unit tests on ambari-server, and reproduced and fixed on a live cluster.

----------------------------------------------------------------------
Total run:679
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez