You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Arvind Prabhakar (JIRA)" <ji...@apache.org> on 2010/02/25 03:24:27 UTC
[jira] Created: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
---------------------------------------------------------------------------------------------------------
Key: HIVE-1198
URL: https://issues.apache.org/jira/browse/HIVE-1198
Project: Hadoop Hive
Issue Type: Improvement
Components: Build Infrastructure
Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
Reporter: Arvind Prabhakar
Priority: Minor
As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated HIVE-1198:
-----------------------------------
Attachment: HIVE-1198.patch
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873236#action_12873236 ]
Ning Zhang commented on HIVE-1198:
----------------------------------
The new patch looks good. I will commit after the tests pass.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871880#action_12871880 ]
Ning Zhang commented on HIVE-1198:
----------------------------------
Arvind, after installing checkstyle indicated in README and your package, eclipse is extremely slow in compiling. It stucked in 36% and I have to kill it. Did you see the same thing?
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871898#action_12871898 ]
Ning Zhang commented on HIVE-1198:
----------------------------------
I did everything from scratch as you mentioned. Whenever I refresh the project, it got stuck in ~36% (for at least 3 mins before I killed it). BTW, I'm using the latest checkstyle version 5.1, eclipse SDK 3.6.0 build I20100312-1448 on linux.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated HIVE-1198:
-----------------------------------
Status: Patch Available (was: Open)
This patch address this issue as follows:
1. The .checkstyle file's match pattern has been changed. This is done to exclude top-level ant directory from being included in the checkstyle application path. Since this is not a valid source directory, it causes checkstyle to report errors for all matching files within it.
2. The build file - build.xml has been modified to exclude {{ant}} directory from processing under the checkstyle target for the same reason as above.
3. The {{eclipse-templates/.project}} file has been modified to include the {{CheckstyleBuilder}} and {{CheckstyleNature}}. This would automatically enable checkstyle when the project is imported in Eclipse. I tested out the scenario of importing the project in Eclipse without having the checkstyle plugin installed - it did not seem to cause any noticeable problem.
4. The section on {{Developing Hive using Eclipse}} in the README.txt has been updated to state that the user must install Checkstyle plugin in eclipse if not already present before importing the project.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838508#action_12838508 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
Missed out a change description in my previous comment:
5. Modified the {{checkstyle/checkstyle.xml}} to set the default value of {{severity}} as {{warning}}.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871968#action_12871968 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
I just installed freshly downloaded eclipse on Ubuntu desktop 9.10, with Java 1.6.0_20, checkstyle 5.1. The version of eclipse build is 20100218-1602 (latest galileo SR2 build). I was able to import the project in under 45 seconds.
Since you are using version 3.6 of eclipse that is not yet released, perhaps that is why you are seeing this problem. Can you try reproducing this issue with a stable release of eclipse such as galileo SR2?
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872296#action_12872296 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
Ning - I have attached an updated patch - (hive-1198-2.patch). The key difference in this patch is that it does not activate checkstyle by default. When you import the hive project and you wish to activate checkstyle, you will have to right click on the project and select Checkstyle > Activate Checkstyle from the context menu.
So in case checkstyle is causing problems on your workbench, you can choose to not activate it. The steps to activate checkstyle plugin in eclipse are also documented in the README.txt file, right below the section on setting up Eclipse.
Can you give this patch a try and see if it resolves the problem you were facing?
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated HIVE-1198:
-----------------------------------
Attachment: HIVE-1198-1.patch
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871839#action_12871839 ]
Ning Zhang commented on HIVE-1198:
----------------------------------
+1 will commit if tests pass.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated HIVE-1198:
-----------------------------------
Attachment: HIVE-1198-2.patch
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned HIVE-1198:
--------------------------------------
Assignee: Arvind Prabhakar
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871952#action_12871952 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
I will try to reproduce this on a linux box and note any findings in the comments.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838495#action_12838495 ]
Carl Steinbach commented on HIVE-1198:
--------------------------------------
+1 Changes look good.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ning Zhang updated HIVE-1198:
-----------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 0.6.0
Resolution: Fixed
Committed. Thanks Arvind!
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Fix For: 0.6.0
>
> Attachments: HIVE-1198-1.patch, HIVE-1198-2.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871882#action_12871882 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
I do not see any slow down Ning. I tested it just now and the project imports and builds under 40 seconds.
Did you do the ant package, model-jar and gen-test before importing the project in eclipse? Without doing that, eclipse will not find the necessary classpath entires and that could lead to slow down.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1198) When checkstyle is activated for Hive
in Eclipse environment, it shows all checkstyle problems as errors.
Posted by "Arvind Prabhakar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871830#action_12871830 ]
Arvind Prabhakar commented on HIVE-1198:
----------------------------------------
Updated the patch so that it cleanly applies to the trunk. It will be great to have this patch committed as it really helps in using eclipse effectively.
> When checkstyle is activated for Hive in Eclipse environment, it shows all checkstyle problems as errors.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HIVE-1198
> URL: https://issues.apache.org/jira/browse/HIVE-1198
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Environment: Mac OS X (10.6.2), Eclipse 3.5.1.R35, Checkstyle Plugin 5.1.0.201002232103 (latest eclipse and checkstyle build as of 02/2010)
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Priority: Minor
> Attachments: HIVE-1198-1.patch, HIVE-1198.patch
>
>
> As of now, checkstyle plugin reports all problems as errors. This causes an overwhelming number of errors to show up (3000+) which masks real errors that might be there. Since all the checkstyle violations are not going to be fixed in one shot, it is desirable to lower the severity of checkstyle violations to warnings so that the plugin can be kept enabled. This will encourage developers to spot checkstyle violations in the files they touch and potentially fix them as they go along, along with pointing out violations as they code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.