You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2019/06/20 15:48:43 UTC
[kudu] branch branch-1.10.x updated (86a0dc2 -> 8c14990)
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a change to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git.
from 86a0dc2 KUDU-2871 (part 1): disable TLS 1.3.
new 556c720 KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)
new c5f4398 [docs] Ubuntu 18.04 is a supported platform
new 8c14990 [tablet_copy_client-test] fix compiler warning
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
docs/installation.adoc | 4 ++--
src/kudu/gutil/port.h | 10 ++++------
src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
3 files changed, 7 insertions(+), 9 deletions(-)
[kudu] 03/03: [tablet_copy_client-test] fix compiler warning
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 8c149902f4b226170ed78aef35de15b2d5696ca3
Author: Alexey Serbin <as...@cloudera.com>
AuthorDate: Tue Jun 18 16:41:23 2019 -0700
[tablet_copy_client-test] fix compiler warning
Fixed compilation warning in TabletCopyClientTest:
src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
warning: 'GenerateTestData' overrides a member function but \
is not marked 'override' [-Winconsistent-missing-override]
virtual void GenerateTestData() {
^
src/kudu/tserver/tablet_copy-test-base.h:113:16: \
note: overridden virtual function is here
virtual void GenerateTestData() {
^
1 warning generated.
This patch does not contain any functional modifications.
Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Reviewed-on: http://gerrit.cloudera.org:8080/13674
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit d0db4c4cd36c1388e36576742cc7fe8c3adfcb77)
Reviewed-on: http://gerrit.cloudera.org:8080/13688
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/tserver/tablet_copy_client-test.cc b/src/kudu/tserver/tablet_copy_client-test.cc
index 5dd9f4e..c24adb6 100644
--- a/src/kudu/tserver/tablet_copy_client-test.cc
+++ b/src/kudu/tserver/tablet_copy_client-test.cc
@@ -146,7 +146,7 @@ class TabletCopyClientTest : public TabletCopyTest {
Status CompareFileContents(const string& path1, const string& path2);
// Injection of 'supports_live_row_count' modifiers through polymorphic characteristic.
- virtual void GenerateTestData() {
+ void GenerateTestData() override {
Random rand(SeedRandom());
NO_FATALS(tablet_replica_->tablet_metadata()->
set_supports_live_row_count_for_tests(rand.Next() % 2));
[kudu] 02/03: [docs] Ubuntu 18.04 is a supported platform
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit c5f4398a7106a58808ef00a57f168973730fd9ac
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Thu Jun 20 01:23:53 2019 -0700
[docs] Ubuntu 18.04 is a supported platform
Once KUDU-2427 and KUDU-2871 are resolved, Kudu can run at
Ubuntu 18.04 LTS (bionic).
Change-Id: I633dc0a525bb1aac77a58755b535831ce436b79b
Reviewed-on: http://gerrit.cloudera.org:8080/13685
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 02fa2d639f7ab8f50af21cd23967da42a4f7cde0)
Reviewed-on: http://gerrit.cloudera.org:8080/13687
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
docs/installation.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/installation.adoc b/docs/installation.adoc
index 710423b..a65792b 100644
--- a/docs/installation.adoc
+++ b/docs/installation.adoc
@@ -44,8 +44,8 @@ only tolerate a single failure; two-master deployments cannot tolerate any failu
.Operating System Requirements
Linux::
- - RHEL 6, RHEL 7, CentOS 6, CentOS 7, Ubuntu 14.04 (Trusty), Ubuntu 16.04 (Xenial), Debian 8
- (Jessie), or SLES 12.
+ - RHEL 6, RHEL 7, CentOS 6, CentOS 7, Ubuntu 14.04 (trusty), Ubuntu 16.04 (xenial),
+ Ubuntu 18.04 (bionic), Debian 8 (Jessie), or SLES 12.
- A kernel and filesystem that support _hole punching_. Hole punching is the use of the
`fallocate(2)` system call with the `FALLOC_FL_PUNCH_HOLE` option set. See
link:troubleshooting.html#req_hole_punching[troubleshooting hole punching] for more
[kudu] 01/03: KUDU-2869. Fix compiler error with devtoolset-7 (gcc
7)
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
granthenke pushed a commit to branch branch-1.10.x
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 556c72043cbab59174b009f4f4cf3bb9aa8d7e85
Author: Todd Lipcon <to...@apache.org>
AuthorDate: Wed Jun 19 00:09:58 2019 -0700
KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)
For whatever reason, some particular C++ syntax used in port.h caused
gcc 7 to crash with an internal error during compilation. This just
rephrases the code in a different way to avoid the issue.
Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
Reviewed-on: http://gerrit.cloudera.org:8080/13677
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/gutil/port.h | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/kudu/gutil/port.h b/src/kudu/gutil/port.h
index 0cf416e..f0b06d7 100644
--- a/src/kudu/gutil/port.h
+++ b/src/kudu/gutil/port.h
@@ -1192,10 +1192,9 @@ using enable_if_numeric = std::enable_if<
// int32_t x = UnalignedLoad<int32_t>(void_ptr);
//
template<typename T,
- typename port_internal::enable_if_numeric<T>::type* = nullptr,
- bool USE_REINTERPRET = port_internal::LoadByReinterpretCast<T>()>
+ typename port_internal::enable_if_numeric<T>::type* = nullptr>
inline T UnalignedLoad(const void* src) {
- if (USE_REINTERPRET) {
+ if (port_internal::LoadByReinterpretCast<T>()) {
return *reinterpret_cast<const T*>(src);
}
T ret;
@@ -1213,10 +1212,9 @@ inline T UnalignedLoad(const void* src) {
// NOTE: this reverses the usual style-guide-suggested order of arguments
// to match the more natural "*p = v;" ordering of a normal store.
template<typename T,
- typename port_internal::enable_if_numeric<T>::type* = nullptr,
- bool USE_REINTERPRET = port_internal::LoadByReinterpretCast<T>()>
+ typename port_internal::enable_if_numeric<T>::type* = nullptr>
inline void UnalignedStore(void* dst, const T& src) {
- if (USE_REINTERPRET) {
+ if (port_internal::LoadByReinterpretCast<T>()) {
*reinterpret_cast<T*>(dst) = src;
} else {
memcpy(dst, &src, sizeof(T));