[GitHub] [incubator-mxnet] jmracek opened a new pull request #19076: fix block.export (#17970)

[GitBox <gi...@apache.org>]

jmracek opened a new pull request #19076:
URL: https://github.com/apache/incubator-mxnet/pull/19076


   This PR cherry-picks commit 5122d32 into the v1.7.x branch. This is to enable the export of models where dangling layers are optimized out during symbol export. For more information, see here and here.
   
   * fix block.export
   
   ```net.hybridize``` may optimize out some ops. These ops are alive in nn.Block(also nn.HybridBlock), but its names are not contained in symbol's ```arg_names``` list. So ignore these ops except that their name are end with 'running_mean' or 'running_var'.
   
   * Update block.py
   
   let user can save their extra param.
   
   * add allow_extra
   
   add allow_extra to let user decide whether to save extra parameters or not.
   
   * Update block.py
   
   add moving_mean and moving_var when export model with SymbolBlock
   
   * Update python/mxnet/gluon/block.py
   
   typo
   
   Co-authored-by: Sheng Zha <sz...@users.noreply.github.com>
   
   * Update block.py
   
   * Update block.py
   
   * Update python/mxnet/gluon/block.py
   
   Co-authored-by: Leonard Lausen <le...@lausen.nl>
   
   Co-authored-by: Sheng Zha <sz...@users.noreply.github.com>
   Co-authored-by: Leonard Lausen <le...@lausen.nl>
   
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19076: fix block.export (#17970)

[GitBox <gi...@apache.org>]

mxnet-bot commented on pull request #19076:
URL: https://github.com/apache/incubator-mxnet/pull/19076#issuecomment-685989370


   Hey @jmracek , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, clang, miscellaneous, centos-gpu, website, unix-cpu, sanity, unix-gpu, windows-cpu, edge, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org