[GitHub] [spark] gatorsmile commented on a change in pull request #25769: [SPARK-29032][CORE] Add PrometheusServlet to monitor Master/Worker/Driver

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #25769: [SPARK-29032][CORE] Add PrometheusServlet to monitor Master/Worker/Driver
URL: https://github.com/apache/spark/pull/25769#discussion_r331765392
 
 

 ##########
 File path: conf/metrics.properties.template
 ##########
 @@ -192,4 +201,10 @@
 
 #driver.source.jvm.class=org.apache.spark.metrics.source.JvmSource
 
-#executor.source.jvm.class=org.apache.spark.metrics.source.JvmSource
\ No newline at end of file
+#executor.source.jvm.class=org.apache.spark.metrics.source.JvmSource
+
+# Example configuration for PrometheusServlet
+#*.sink.prometheusServlet.class=org.apache.spark.metrics.sink.PrometheusServlet
+#*.sink.prometheusServlet.path=/metrics/prometheus
+#master.sink.prometheusServlet.path=/metrics/master/prometheus
+#applications.sink.prometheusServlet.path=/metrics/applications/prometheus
 
 Review comment:
   @dongjoon-hyun Will this swamp the Prometheus server? A lot of metrics of numerous Spark applications will be sent to the central server, for example, `metrics_{$app_id}_driver_BlockManager_disk_diskSpaceUsed_MB_Value 0`
   
   Have you tried to run it ? How to deal with the high load issues? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org