You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Bruno P. Kinoshita (JIRA)" <ji...@apache.org> on 2015/04/04 17:22:33 UTC

[jira] [Commented] (FUNCTOR-30) A catalog of reusable, composable, injectable, interface-compliant, immutable Predicates based on commons.lang utilities

    [ https://issues.apache.org/jira/browse/FUNCTOR-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395774#comment-14395774 ] 

Bruno P. Kinoshita commented on FUNCTOR-30:
-------------------------------------------

Hi EItan! Thank you for your contribution and for the well-written rationale. I'm about to fly to New Zealand, but I'm downloading the patch and re-syncing my local repo. I'll try to review it during the flight and provide some feedback by Tuesday/Wednesday (long trip!). 

Feel free to update the issue or the patch in the meantime.

> A catalog of reusable, composable, injectable, interface-compliant, immutable  Predicates  based on commons.lang utilities
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FUNCTOR-30
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-30
>             Project: Commons Functor
>          Issue Type: Wish
>    Affects Versions: 1.0
>            Reporter: Eitan Raviv
>            Priority: Minor
>              Labels: features, newbie, patch
>             Fix For: 1.0
>
>         Attachments: predicates.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> The Predicate framework does not propose meaningful basic implementations for queries that have been deemed common enough by commons.lang to merit numerous utility methods (actually functions). This leaves developers with the work-intensive, error-prone, low-level task of recreating objectified variants of these utilities whenever they wish to pass such queries around in code. Moreover, the lack of these implementations encourages developers to use static code, which proliferates as a convention into their application code and may encourage the opposite of 'clean code' (and I have seen a truck-load of that). I would like to see the ASF set an example and provide a working set of basic components for developers OOTB.
> I am submitting an initial draft patch for a review of my basic idea. If I receive an approval, I will create a complete patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)