You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/09/24 21:11:32 UTC
[jira] Created: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Clover build doesn't generate per-test coverage
-----------------------------------------------
Key: HADOOP-6971
URL: https://issues.apache.org/jira/browse/HADOOP-6971
Project: Hadoop Common
Issue Type: Bug
Components: build, test
Affects Versions: 0.20.3, 0.21.1, 0.22.0
Reporter: Konstantin Boudnik
Assignee: Konstantin Boudnik
Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6971:
---------------------------------------
Release Note: This fix requires that test coverage is running under Clover 3.0+
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.1
>
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6971:
---------------------------------------
Attachment: HADOOP-6971.y20S.patch
Patch for y20-security (should work for 0.20 branch as well).
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923584#action_12923584 ]
Hudson commented on HADOOP-6971:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #395 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/])
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.1
>
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6971:
---------------------------------------
Attachment: HADOOP-6971.patch
Fix for the problem
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6971.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916743#action_12916743 ]
Giridharan Kesavan commented on HADOOP-6971:
--------------------------------------------
+1 Looks good.
Tested on 0.21 and 0.22
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914610#action_12914610 ]
Konstantin Boudnik commented on HADOOP-6971:
--------------------------------------------
Code coverage reports provided by Clover runs (e.g. [here|https://hudson.apache.org/hudson/view/Hadoop/job/Hadoop-Common-trunk/clover] show the information about covered classes, methods, and so on.
However, no tests info is shown. It simply says
{noformat}
Test Results 0 / 0 tests 0 secs
No test results could be found. Please ensure that you have instrumented your unit tests correctly.
{noformat}
Apparently, Clover can't find and instrumented any tests classes in the source code.
Same issues is found in HDFS and MR.
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915475#action_12915475 ]
Konstantin Boudnik commented on HADOOP-6971:
--------------------------------------------
I have ran patched build and can confirm that it works both for 0.20 branch and 0.22 Common - all tests are running as expected (some are failing, but they are failing for a long time). There's no way to verify it via {{test-patch}} so I think it just has to be committed as is.
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923832#action_12923832 ]
Hudson commented on HADOOP-6971:
--------------------------------
Integrated in Hadoop-Common-trunk #489 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/])
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.1
>
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6971) Clover build doesn't generate
per-test coverage
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik resolved HADOOP-6971.
----------------------------------------
Hadoop Flags: [Reviewed]
Fix Version/s: 0.21.1
Resolution: Fixed
I have committed this to the trunk and 0.21.
This chance requires Clover 3.0+ to be used for test coverage runs.
> Clover build doesn't generate per-test coverage
> -----------------------------------------------
>
> Key: HADOOP-6971
> URL: https://issues.apache.org/jira/browse/HADOOP-6971
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 0.20.3, 0.21.1, 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.1
>
> Attachments: HADOOP-6971.patch, HADOOP-6971.y20S.patch
>
>
> Because of the way the structure of Hadoop's builds is done Clover can't properly detect test classes among the sources. As the result clover reports are incomplete and do not provide viral per-test coverage info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.