You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Jay357089 <gi...@git.apache.org> on 2016/11/16 02:57:26 UTC
[GitHub] incubator-carbondata pull request #320: [CARBONDATA-412][WIP]Fix load bug wh...
GitHub user Jay357089 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/320
[CARBONDATA-412][WIP]Fix load bug when table name has '_'
https://issues.apache.org/jira/browse/CARBONDATA-412
## Reason:
this is because in windows, file separator is "\", then in getSegmentId method, when split with
linux file separator "/", carbon can not get the correct segment number, then the segment is treated as an invalid segment and will be deleted..
## Solution:
the file path should be firstly replaced with file separator "/"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jay357089/incubator-carbondata fixTableWithUnderScore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #320
----
commit 6ac0532514d3960649fb5ab23c845365fef20250
Author: Jay357089 <li...@huawei.com>
Date: 2016-11-16T02:49:35Z
fix load bug when table name has '_'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
Build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/229/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #320: [CARBONDATA-412] Fix load bug when t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/223/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
ready to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #320: [CARBONDATA-412] Fix load bug when table na...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/320
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/210/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #320: [CARBONDATA-412] Fix load bug when t...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/320#discussion_r92975241
--- Diff: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala ---
@@ -22,27 +22,56 @@ package org.apache.carbondata.integration.spark.testsuite.dataload
import java.io.File
import java.math.BigDecimal
+import org.apache.carbondata.core.carbon.path.{CarbonStorePath, CarbonTablePath}
+import org.apache.carbondata.core.datastorage.store.filesystem.CarbonFile
+import org.apache.carbondata.core.datastorage.store.impl.FileFactory
import org.apache.spark.sql.Row
import org.apache.spark.sql.common.util.CarbonHiveContext._
-import org.apache.spark.sql.common.util.QueryTest
+import org.apache.spark.sql.common.util.{CarbonHiveContext, QueryTest}
import org.scalatest.BeforeAndAfterAll
+import scala.collection.mutable.ArrayBuffer
+
class TestLoadDataGeneral extends QueryTest with BeforeAndAfterAll {
var currentDirectory: String = _
override def beforeAll {
sql("DROP TABLE IF EXISTS loadtest")
+ sql("DROP TABLE IF EXISTS load_test")
sql(
"""
| CREATE TABLE loadtest(id int, name string, city string, age int)
| STORED BY 'org.apache.carbondata.format'
""".stripMargin)
+ sql(
--- End diff --
done. pls check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---