You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by boynet <gi...@git.apache.org> on 2015/04/15 19:54:42 UTC
[GitHub] cordova-android pull request: fix package name validation
GitHub user boynet opened a pull request:
https://github.com/apache/cordova-android/pull/174
fix package name validation
you can see accepted applications in google play that contain number in the first part of package name, those apps cant be build with because of this validation bug\inconsistent with google play. for example this package: http://bit.ly/1aVO6Re
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/boynet/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 60891d880f7c17250b176c3e76ec93d23471f9ff
Author: boynet <bo...@gmail.com>
Date: 2015-04-15T17:53:50Z
fix package name validation
you can see accepted applications in google play that contain number in the first part of package name, those apps cant be build with because of this validation bug\inconsistent with google play. for example this package: http://bit.ly/1aVO6Re
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93529519
I do believe that the first letter of the name cannot be a number, which is what the current regexp checks for (non-first characters can be numbers)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93536760
The platform agnostic version of this check is here:
https://github.com/purplecabbage/valid-identifier/blob/master/valid-identifier.js
The regex in use should probably be the same as there.
var regX = /([a-zA-Z_$][a-zA-Z\d_$]*\.)*[a-zA-Z_$][a-zA-Z\d_$]*/;
or refactored to use valid-identifier.
validateIdentifier("be111.net") passes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93614422
@boynet - your fiddle doesn't use the regex that's checked in.
http://jsfiddle.net/hakxc2uv/
shows that the regexp as-is works fine for your case (I just copied and pasted it from the "Files changed" section of this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by boynet <gi...@git.apache.org>.
Github user boynet closed the pull request at:
https://github.com/apache/cordova-android/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by boynet <gi...@git.apache.org>.
Github user boynet commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93667642
@agrieve omg you are right, thanks.
i saw it here https://github.com/crosswalk-project/crosswalk-cordova-android/blob/master/bin/lib/create.js#L161 and I was sure they just fork you version sorry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: fix package name validation
Posted by boynet <gi...@git.apache.org>.
Github user boynet commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93530816
this package name failed: "be111.net" with the error of "Package name must look like: com.company.Name" although is accepted by google so maybe something else in the regex is wrong but the fix I made fix it for me you can see simmilar package name here: https://play.google.com/store/apps/details?id=be106.net
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org