You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/02/10 13:55:03 UTC

Review Request: HIVE-1983: Bundle Log4j configuration files in Hive JARs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/416/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Review for HIVE-1893.


This addresses bug HIVE-1983.
    https://issues.apache.org/jira/browse/HIVE-1983


Diffs
-----

  build-common.xml 6bf5d3c 
  build.xml 25f8945 
  common/build.xml d9ac07e 
  common/src/java/conf/hive-log4j.properties PRE-CREATION 
  conf/hive-exec-log4j.properties 5f56ca4 
  conf/hive-log4j.properties 9e2a1cc 
  ql/build.xml 50c604e 
  ql/src/java/conf/hive-exec-log4j.properties PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 2f416a0 

Diff: https://reviews.apache.org/r/416/diff


Testing
-------

1) Ran hivecli with INFO level logging enabled via -hiveconf switch. Verified that INFO message printed stating that hive-log4j.properties file was picked up from common JAR.
2) Placed a copy of hive-log4j.properties in $HIVE_HOME/conf. Verified that INFO message printed stating that hive-log4j.properties file was picked up from $HIVE_HOME/conf


Thanks,

Carl