[GitHub] [daffodil-vscode] arosien commented on a diff in pull request #582: omega-edit client get specified port from launch.json

["arosien (via GitHub)" <gi...@apache.org>]

arosien commented on code in PR #582:
URL: https://github.com/apache/daffodil-vscode/pull/582#discussion_r1169468499


##########
src/dataEdit/client.ts:
##########
@@ -80,9 +80,29 @@ function getPidFile(serverPort: number) {
 
 async function getOmegaEditPort() {
   if (omegaEditPort === 0) {
-    omegaEditPort = vscode.workspace
-      .getConfiguration('dataEditor')
-      .get<number>('omegaEditPort', DEFAULT_OMEGA_EDIT_PORT)
+    /**

Review Comment:
   I don't think this code is necessary; see https://github.com/apache/daffodil-vscode/issues/579#issuecomment-1512406554



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org