You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Rick McGuire (JIRA)" <de...@geronimo.apache.org> on 2005/10/20 19:38:50 UTC

[jira] Created: (GERONIMO-1096) Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs

Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs
------------------------------------------------------------------------------

         Key: GERONIMO-1096
         URL: http://issues.apache.org/jira/browse/GERONIMO-1096
     Project: Geronimo
        Type: Bug
  Components: OpenEJB  
    Versions: 1.0-M5    
 Environment: Any using a non-Sun JDK. 
    Reporter: Rick McGuire


The copy() methods for ServerPolicy and ClientPolicy are hard-coded to return null.  This is gotten away with on the Sun ORB, but on at least the IBM ORB, policy objects are frequently copied to ensure a non-shared copy of user-defined policy objects is used.  Returning null in this case causes lots of interesting failures in the ORB code.  These classes should properly honor the Policy interface contract and return a copy. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-1096) Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1096?page=all ]

David Jencks reassigned GERONIMO-1096:
--------------------------------------

    Assign To: David Jencks

> Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs
> ------------------------------------------------------------------------------
>
>          Key: GERONIMO-1096
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1096
>      Project: Geronimo
>         Type: Bug
>   Components: OpenEJB
>     Versions: 1.0-M5
>  Environment: Any using a non-Sun JDK. 
>     Reporter: Rick McGuire
>     Assignee: David Jencks
>  Attachments: ServerPolicy.patch
>
> The copy() methods for ServerPolicy and ClientPolicy are hard-coded to return null.  This is gotten away with on the Sun ORB, but on at least the IBM ORB, policy objects are frequently copied to ensure a non-shared copy of user-defined policy objects is used.  Returning null in this case causes lots of interesting failures in the ORB code.  These classes should properly honor the Policy interface contract and return a copy. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1096) Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1096?page=all ]
     
David Jencks closed GERONIMO-1096:
----------------------------------

    Fix Version: 1.0
     Resolution: Fixed

Applied.   Do these classes need equals and hashcode methods?  Also, should the copy method copy the underlying CSSConfig and TSSConfig? currently they are shared between source and copy, apparently eliminating the point of constructing a new Policy object.

Checking in modules/core/src/java/org/openejb/corba/security/ClientPolicy.java;
new revision: 1.2; previous revision: 1.1
Checking in modules/core/src/java/org/openejb/corba/security/ServerPolicy.java;
new revision: 1.3; previous revision: 1.2



> Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs
> ------------------------------------------------------------------------------
>
>          Key: GERONIMO-1096
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1096
>      Project: Geronimo
>         Type: Bug
>   Components: OpenEJB
>     Versions: 1.0-M5
>  Environment: Any using a non-Sun JDK. 
>     Reporter: Rick McGuire
>     Assignee: David Jencks
>      Fix For: 1.0
>  Attachments: ServerPolicy.patch
>
> The copy() methods for ServerPolicy and ClientPolicy are hard-coded to return null.  This is gotten away with on the Sun ORB, but on at least the IBM ORB, policy objects are frequently copied to ensure a non-shared copy of user-defined policy objects is used.  Returning null in this case causes lots of interesting failures in the ORB code.  These classes should properly honor the Policy interface contract and return a copy. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1096) Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs

Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1096?page=all ]

Rick McGuire updated GERONIMO-1096:
-----------------------------------

    Attachment: ServerPolicy.patch

A patch to properly implement the copy() method. 

> Incomplete ServerPolicy/ClientPolicy classes causes problems with non-Sun ORBs
> ------------------------------------------------------------------------------
>
>          Key: GERONIMO-1096
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1096
>      Project: Geronimo
>         Type: Bug
>   Components: OpenEJB
>     Versions: 1.0-M5
>  Environment: Any using a non-Sun JDK. 
>     Reporter: Rick McGuire
>  Attachments: ServerPolicy.patch
>
> The copy() methods for ServerPolicy and ClientPolicy are hard-coded to return null.  This is gotten away with on the Sun ORB, but on at least the IBM ORB, policy objects are frequently copied to ensure a non-shared copy of user-defined policy objects is used.  Returning null in this case causes lots of interesting failures in the ORB code.  These classes should properly honor the Policy interface contract and return a copy. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira