[GitHub] [hbase] nkalmar commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload

[GitBox <gi...@apache.org>]

nkalmar commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload
URL: https://github.com/apache/hbase/pull/494#discussion_r323190279
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
 ##########
 @@ -243,14 +250,26 @@ public void replicateEntries(List<WALEntry> entries, final CellScanner cells,
         LOG.debug("Finished replicating mutations.");
       }
 
-      if (bulkLoadHFileMap != null && !bulkLoadHFileMap.isEmpty()) {
-        LOG.debug("Started replicating bulk loaded data.");
-        HFileReplicator hFileReplicator =
-            new HFileReplicator(this.provider.getConf(this.conf, replicationClusterId),
+      if(bulkLoadsPerClusters != null) {
+        for (List<String> clusterIds : bulkLoadsPerClusters.keySet()) {
 
 Review comment:
   Is there a reason String is used for clusterId? 
   I see UUID used elsewhere in this class. like:
   List<UUID> clusterIds = new ArrayList<>(entry.getKey().getClusterIdsList().size());

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services