You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/13 22:23:28 UTC
Review Request 67918: Updated documentation for `CREATE_DISK` and
`DESTROY_DISK`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67918/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.
Diffs
-----
docs/csi.md 7c38fc10633aa28d012606150099ab5cc4b60cb6
docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
Diff: https://reviews.apache.org/r/67918/diff/1/
Testing
-------
Spell checked.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67918: Updated documentation for `CREATE_DISK` and
`DESTROY_DISK`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67918/
-----------------------------------------------------------
(Updated July 26, 2018, 9:15 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comment.
Repository: mesos
Description
-------
Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.
Diffs (updated)
-----
docs/csi.md 5f50ee980a1219b2d2d17bc3a47a66a3bf231831
docs/monitoring.md 336f3aa7d2440e826765ae2bf022a5f6acac2927
Diff: https://reviews.apache.org/r/67918/diff/2/
Changes: https://reviews.apache.org/r/67918/diff/1-2/
Testing
-------
Spell checked.
Thanks,
Chun-Hung Hsiao
Re: Review Request 67918: Updated documentation for `CREATE_DISK` and
`DESTROY_DISK`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67918/#review206439
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
docs/csi.md
Line 196 (original), 195 (patched)
<https://reviews.apache.org/r/67918/#comment289386>
Since we are at it we should `s/2/two/`.
- Benjamin Bannier
On July 14, 2018, 12:23 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67918/
> -----------------------------------------------------------
>
> (Updated July 14, 2018, 12:23 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.
>
>
> Diffs
> -----
>
> docs/csi.md 7c38fc10633aa28d012606150099ab5cc4b60cb6
> docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
>
>
> Diff: https://reviews.apache.org/r/67918/diff/1/
>
>
> Testing
> -------
>
> Spell checked.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67918: Updated documentation for `CREATE_DISK` and
`DESTROY_DISK`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67918/#review206083
-----------------------------------------------------------
PASS: Mesos patch 67918 was successfully built and tested.
Reviews applied: `['67918']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1924/mesos-review-67918
- Mesos Reviewbot Windows
On July 13, 2018, 10:23 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67918/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 10:23 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated documentation for `CREATE_DISK` and `DESTROY_DISK`.
>
>
> Diffs
> -----
>
> docs/csi.md 7c38fc10633aa28d012606150099ab5cc4b60cb6
> docs/monitoring.md 2f06e9b7b05d9cd3f447cbd3eab43bc493e25cd1
>
>
> Diff: https://reviews.apache.org/r/67918/diff/1/
>
>
> Testing
> -------
>
> Spell checked.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>