You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 00:07:04 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5825: [HUDI-4217] improve repeat init object in ExpressionPayload

xushiyan commented on code in PR #5825:
URL: https://github.com/apache/hudi/pull/5825#discussion_r930507915


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/SqlTypedRecord.scala:
##########
@@ -17,27 +17,59 @@
 
 package org.apache.spark.sql.hudi.command.payload
 
+import com.google.common.cache.CacheBuilder

Review Comment:
   filed
   https://issues.apache.org/jira/browse/HUDI-4482 -> remove guava
   https://issues.apache.org/jira/browse/HUDI-4483 -> fix checkstyle
   
   @KnightChess would you take these?  i see guava heavily used in procedure, @XuQianJin-Stars maybe you can help review?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org