[jira] [Commented] (METRON-931) Stellar REDUCE incorrectly returns null for fewer than 3 items in list

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997416#comment-15997416 ] 

ASF GitHub Bot commented on METRON-931:
---------------------------------------

GitHub user mmiklavc opened a pull request:

    https://github.com/apache/incubator-metron/pull/565

    METRON-931: Stellar REDUCE incorrectly returns null for fewer than 3 items in list

    https://issues.apache.org/jira/browse/METRON-931
    
    Reduce was checking input.size() instead of args.size(). The input var is the first arg to the reduce function, so it was returning null if fewer than 3 items existed in the list. I've corrected the function to return null if the number of arguments to the function itself is fewer than the expected 3.
    
    A simple set of unit tests has been added. This can also be manually tested by starting the Stellar REPL and testing that the following calls do not return null:
    ```
    h1 := REDUCE(['foo', 'bar'], (s, x) -> HLLP_ADD(s, x), HLLP_INIT(5, 6))
    s1 := REDUCE([1,2], (s, x) -> STATS_ADD(s, x), STATS_INIT())
    ```
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/incubator-metron METRON-931

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #565
    
----
commit efd90e188e6cff1148f23111273a596e29c7692f
Author: Michael Miklavcic <mi...@gmail.com>
Date:   2017-05-04T20:46:32Z

    METRON-931: Stellar REDUCE incorrectly returns null for fewer than 3 items in list

----


> Stellar REDUCE incorrectly returns null for fewer than 3 items in list
> ----------------------------------------------------------------------
>
>                 Key: METRON-931
>                 URL: https://issues.apache.org/jira/browse/METRON-931
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>
> Examples:
> OK:
> {code}
> h1 := REDUCE(['foo', 'bar', 'baz'], (s, x) -> HLLP_ADD(s, x), HLLP_INIT(5, 6))
> s1 := REDUCE([1,2,3], (s, x) -> STATS_ADD(s, x), STATS_INIT())
> {code}
> Not OK:
> {code}
> h1 := REDUCE(['foo', 'bar'], (s, x) -> HLLP_ADD(s, x), HLLP_INIT(5, 6))
> s1 := REDUCE([1,2], (s, x) -> STATS_ADD(s, x), STATS_INIT())
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)