You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2010/08/06 21:52:18 UTC
[jira] Updated: (WICKET-2974) IFeedback that is child of IFeedback
gets added to the FEEDBACK_LIST too late
[ https://issues.apache.org/jira/browse/WICKET-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-2974:
-------------------------------------
Attachment: quickstart.tar.gz
WICKET-2974.patch
> IFeedback that is child of IFeedback gets added to the FEEDBACK_LIST too late
> -----------------------------------------------------------------------------
>
> Key: WICKET-2974
> URL: https://issues.apache.org/jira/browse/WICKET-2974
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.9
> Reporter: Jeremy Thomerson
> Assignee: Jeremy Thomerson
> Priority: Trivial
> Fix For: 1.4.10
>
> Attachments: quickstart.tar.gz, WICKET-2974.patch
>
>
> Consider the following scenario:
> - I have a BasePage that I add a feedback panel to. I want it to only render feedback messages that have not been rendered by any other feedback panels
> - I have a feedback border that implements IFeedback, and inside it, I also have a FeedbackPanel. I want the feedback panel to only render the messages pertaining to the components within the border.
> To accomplish this, I put the creation of the feedback panel in the BasePage in onBeforeRender so that my component hierarchy (including the border and it's child feedback panel) is created before I add myself to the hierarchy. By doing this, I expect my page to be the last IFeedback to appear in the feedback list.
> But alas, when Component#beforeRender creates the list of IFeedback components, it effectively stops the traversal of any IFeedback#beforeRender calls because it does not call internalBeforeRender().
> The attached quickstart demonstrates the problem, and the patch fixes it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.