You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 14:18:47 UTC

[GitHub] [incubator-superset] kgabryje opened a new pull request #11975: chore: Change paddings on ListView and SubMenu

kgabryje opened a new pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975


   ### SUMMARY
   Decreases paddings around filter row on DashboardList, ChartList and other views with SubMenu and ListView.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: see linked issue
   After:
   ![image](https://user-images.githubusercontent.com/15073128/101640406-c0a7dd80-3a30-11eb-9173-0abf9046e47e.png)
   
   ### TEST PLAN
   Manually verify that views with SubMenu and ListView still look good
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/incubator-superset/issues/11965
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975#issuecomment-742607367


   > closes #11965
   > 
   > @kgabryje protip: if you write `closes https://github.com/apache/incubator-superset/issues/11965` in your PR top comment it'll link to the issue and auto-close it when the PR gets merged
   
   Thanks, good to know!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975#issuecomment-741936791


   closes https://github.com/apache/incubator-superset/issues/11965


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975#issuecomment-741834762


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=h1) Report
   > Merging [#11975](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=desc) (dde79d1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cc44a2c01b31e0f51eb8bdfe70d7989b245228e4?el=desc) (cc44a2c) will **decrease** coverage by `12.43%`.
   > The diff coverage is `45.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11975/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #11975       +/-   ##
   ===========================================
   - Coverage   66.26%   53.83%   -12.44%     
   ===========================================
     Files         941      431      -510     
     Lines       45715    15201    -30514     
     Branches     4395     3885      -510     
   ===========================================
   - Hits        30293     8183    -22110     
   + Misses      15287     7018     -8269     
   + Partials      135        0      -135     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.83% <45.45%> (+10.02%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | `62.50% <ø> (-24.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `76.66% <33.33%> (-19.26%)` | :arrow_down: |
   | [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <100.00%> (-16.89%)` | :arrow_down: |
   | [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.10% <100.00%> (-6.90%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [828 more](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=footer). Last update [cc44a2c...dde79d1](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975#issuecomment-741936791


   closes https://github.com/apache/incubator-superset/issues/11965
   
   @kgabryje protip: if you write `closes https://github.com/apache/incubator-superset/issues/11965` in your PR top comment it'll link to the issue and auto-close it when the PR gets merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas merged pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11975: chore: Change paddings on ListView and SubMenu

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11975:
URL: https://github.com/apache/incubator-superset/pull/11975#issuecomment-741834762


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=h1) Report
   > Merging [#11975](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=desc) (dde79d1) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cc44a2c01b31e0f51eb8bdfe70d7989b245228e4?el=desc) (cc44a2c) will **decrease** coverage by `11.86%`.
   > The diff coverage is `45.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11975/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #11975       +/-   ##
   ===========================================
   - Coverage   66.26%   54.40%   -11.87%     
   ===========================================
     Files         941      431      -510     
     Lines       45715    15201    -30514     
     Branches     4395     3885      -510     
   ===========================================
   - Hits        30293     8270    -22023     
   + Misses      15287     6931     -8356     
   + Partials      135        0      -135     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.40% <45.45%> (+10.59%)` | :arrow_up: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | `62.50% <ø> (-24.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `76.66% <33.33%> (-19.26%)` | :arrow_down: |
   | [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <100.00%> (-16.89%)` | :arrow_down: |
   | [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `93.10% <100.00%> (-6.90%)` | :arrow_down: |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [827 more](https://codecov.io/gh/apache/incubator-superset/pull/11975/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=footer). Last update [cc44a2c...dde79d1](https://codecov.io/gh/apache/incubator-superset/pull/11975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org