You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/24 11:06:21 UTC
[GitHub] [airflow] potiuk opened a new pull request, #32116: Avoid permission error when asset compilation exists before killing it
potiuk opened a new pull request, #32116:
URL: https://github.com/apache/airflow/pull/32116
After #32114 the atexit registered killpg produces Permission Error in stdout when the group was missing (basically when the asset compilation stopped).
Changing it to ignore the error avoids the false negative appear in the output.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32116: Avoid permission error when asset compilation exists before killing it
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32116:
URL: https://github.com/apache/airflow/pull/32116#issuecomment-1605395528
Small follow-up. Avoids this:
<img width="462" alt="Screenshot 2023-06-24 at 13 07 10" src="https://github.com/apache/airflow/assets/595491/449d0343-1381-4efc-ba6e-9634bf1d94b2">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32116: Avoid permission error when asset compilation exists before killing it
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32116:
URL: https://github.com/apache/airflow/pull/32116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org