You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/02 14:04:14 UTC
[GitHub] [kafka] ijuma opened a new pull request #11374: MINOR: TopicIdPartition improvements
ijuma opened a new pull request #11374:
URL: https://github.com/apache/kafka/pull/11374
1. It should not require a TopicPartition during construction and normal
usage.
2. Simplify `equals` since `topicId` and `topicPartition` are never
null.
3. Inline `Objects.hash` to avoid array allocation.
4. Make `toString` more concise using a similar approach as
`TopicPartition` since this `TopicIdPartition` will replace
`TopicPartition` in many places in the future.
5. Add unit tests for `TopicIdPartition`, it seems like we had none.
6. Minor clean-up in calling/called classes.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11374:
URL: https://github.com/apache/kafka/pull/11374#issuecomment-932757911
One more thing, this is in a public package. So we need to update the KIP where we introduced this class. @satishd which KIP was that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd commented on pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
satishd commented on pull request #11374:
URL: https://github.com/apache/kafka/pull/11374#issuecomment-932798536
@ijuma `TopicIdPartition` was introduced in KIP-405 but I am not sure whether it needs to be updated as this PR is about enhancing but not breaking or changing anything that was introduced earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd edited a comment on pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
satishd edited a comment on pull request #11374:
URL: https://github.com/apache/kafka/pull/11374#issuecomment-932798536
@ijuma `TopicIdPartition` was introduced in KIP-405 but I am not sure whether KIP needs to be updated as this PR is about enhancing but not breaking or changing what was introduced earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11374:
URL: https://github.com/apache/kafka/pull/11374#issuecomment-932757605
cc @satishd who introduced this class and @jolshan who is using it in #11331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11374:
URL: https://github.com/apache/kafka/pull/11374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] satishd edited a comment on pull request #11374: MINOR: TopicIdPartition improvements
Posted by GitBox <gi...@apache.org>.
satishd edited a comment on pull request #11374:
URL: https://github.com/apache/kafka/pull/11374#issuecomment-932798536
@ijuma `TopicIdPartition` was introduced in KIP-405 but I am not sure whether KIP needs to be updated as this PR is about enhancing but not breaking or changing API that was introduced earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org