You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/10/30 18:42:45 UTC

[GitHub] [metron] nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1

nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1
URL: https://github.com/apache/metron/pull/1551
 
 
   This change includes a few clean-up items that are needed prior to the `feature/METRON-2088-support-hdp-3.1` feature branch being merged into master.  I validated each of the component versions that we are building against to ensure they match against [HDP-3.1](https://docs.cloudera.com/HDPDocuments/HDP3/HDP-3.1.0/release-notes/content/comp_versions.html).
   
   Each of these changes are included in separate commits to make review a bit simpler.  These include.
   
   * Removed the legacy `HDP-2.5.0.0` profile from the root POM.
   * Changed the Spark dependency from 2.3.1 to 2.3.2 to match HDP-3.1
   * Removed a `storm-kafka` dependency from the root POM that was never needed.
   * Moved all properties defining versions of core platform components to the `HDP-3.1` profile.
   * Reorganized existing version properties into separate sections for (1) build dependencies (2) test dependencies and (3) build tooling
   * Removed unused properties.
   * Pulled out some of the build tooling versions into properties to match what we had done in other places.  
   
   I validated this by comparing the version numbers output by `mvn dependency:tree` from before and after the change.  The only version changes introduced by this PR involve the Spark change. This in addition to the basic acceptance testing were used to validate the change.
   
   I'd be happy to break any of these changes out into separate PRs should a reviewer think that is needed.
   
   ## Acceptance Testing
   
   This PR should be tested using the centos7 development environment.  
   
   1. Start up the centos7 dev environment.
       ```
       cd metron-deployment/development/centos7
       vagrant destroy -f
       vagrant up
       ```
   
   ### Basic Indexing and Enrichment
   
   Ensure that we can continue to parse, enrich, and index telemetry.  Verify data is flowing through the system, from parsing to indexing
   
   1. Open Ambari and navigate to the Metron service http://node1:8080/#/main/services/METRON/summary
   
   1. Open the Alerts UI.  Verify alerts show up in the main UI - click the search icon (you may need to wait a moment for them to appear)
   
   1. Go to the Alerts UI and ensure that an ever increasing number of telemetry from Bro, Snort, and YAF are visible by watching the total alert count increase over time.
   
   1. Ensure that geoip enrichment is occurring.  The telemetry should contain fields like `enrichments:geo:ip_src_addr:location_point`.
   
   1. Head back to Ambari and select the Kibana service http://node1:8080/#/main/services/KIBANA/summary
   
   1. Open the Kibana dashboard via the "Metron UI" option in the quick links
   
   1. Verify the dashboard is populating
   
   ## Pull Request Checklist
   
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services