You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/04/12 16:18:53 UTC
[PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
csun5285 opened a new pull request, #62409:
URL: https://github.com/apache/doris/pull/62409
Old versions (cloud-4.1.2 with variant_max_subcolumns_count=0) store a flat JSON key like {"a.b": 1} as a single PathInData part "a.b" in the segment's ColumnPathInfo protobuf. New master compaction builds query paths via PathInData(string) which splits on dots, so the 3-part path does not match the 1-part tree node, find_leaf returns nullptr, and the read plan silently falls back to DEFAULT_FILL. Compaction then rewrites the rowset with empty values, losing the original data.
Normalize the legacy relative path in VariantColumnReader::init() by re-constructing PathInData from its string form. This splits the single-part dot key into multiple parts so the meta tree shape matches what both compaction schema and query path expect.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4241198713
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4241215533
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (25/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 63.19% (23499/37190) |
| Line Coverage | 46.74% (241273/516160) |
| Region Coverage | 43.67% (197353/451879) |
| Branch Coverage | 45.02% (85561/190058) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3079460179
##########
be/src/storage/segment/variant/variant_column_reader.cpp:
##########
@@ -1205,6 +1205,13 @@ Status VariantColumnReader::init(const ColumnReaderOptions& opts, ColumnMetaAcce
_statistics->subcolumns_non_null_size.emplace(relative_path.get_path(),
column_pb.none_null_size());
}
+ // 3.1.2 may store a flat JSON key like {"a.b": 1} as a single PathInData part.
+ // New compaction schema and query path expect a dot-split multi-part shape.
+ // Rebuild via the string constructor when the path has neither typed
+ // nor nested metadata, so the tree matches the new shape.
+ if (!relative_path.get_is_typed() && !relative_path.has_nested_part()) {
Review Comment:
This rewrite is too broad: it reparses every non-typed, non-nested path from its dotted string form, so a legitimate flat key stored as parts `["a.b"]` becomes indistinguishable from a real nested path `["a", "b"]`. Doris already treats those as different valid structures today; `SchemaUtilTest.has_different_structure_in_same_path_indirect` explicitly allows `["a.b"]` and `["a", "b"]` to coexist.
A concrete failure case is a legacy rowset that contains flat key data from `{"a.b": 1}` while another rowset contains nested data from `{"a": {"b": 2}}`. After `init()` both paths collapse onto the same `_subcolumns_meta_info` branch, so readers/compaction can merge or rewrite the wrong values.
The added test does not cover that case because it rewrites a single nested path into the legacy shape and only verifies lookup success. Please add a coexistence test and narrow the compatibility handling so it does not change the canonical meaning of genuine flat dot-keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4237305254
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (25/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 63.22% (23512/37190) |
| Line Coverage | 46.76% (241351/516160) |
| Region Coverage | 43.72% (197581/451879) |
| Branch Coverage | 45.03% (85592/190058) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4237449961
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (25/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 63.23% (23517/37190) |
| Line Coverage | 46.77% (241404/516160) |
| Region Coverage | 43.69% (197444/451879) |
| Branch Coverage | 45.04% (85601/190058) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3073231896
##########
be/src/storage/segment/variant/variant_column_reader.cpp:
##########
@@ -1205,6 +1205,10 @@ Status VariantColumnReader::init(const ColumnReaderOptions& opts, ColumnMetaAcce
_statistics->subcolumns_non_null_size.emplace(relative_path.get_path(),
column_pb.none_null_size());
}
+ // 3.1.2 may store a flat JSON key like {"a.b": 1} as a single PathInData part.
+ // New compaction schema and query path expect a dot-split multi-part shape.
+ // Normalize here before inserting into the meta tree to match that shape.
+ relative_path.normalize_legacy_flat_dot_key();
Review Comment:
会丢掉typed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3071628984
##########
be/src/util/json/path_in_data.cpp:
##########
@@ -224,6 +224,36 @@ PathInData PathInData::copy_pop_back() const {
return new_path;
}
+void PathInData::normalize_legacy_flat_dot_key() {
Review Comment:
如果存的是 v['a']['b']，查询是 v['a.b']，这种是可以的，生成['a.b']迭代器失败了，可以去找 ['a']['b'] 的迭代器。
但是反过来不行，存的是 v['a.b']，查询是v['a']['b']，需要把 a 和 b 拼起来，但是如果是多层的话，就不知道拼哪个了，比如存的是 v['a.b']['c'] ，查询是 v['a']['b']['c'] 怎么确定拼的是 a 和b 还是 b 和c，这种太复杂了，不如直接都打平。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #62409:
URL: https://github.com/apache/doris/pull/62409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4244019254
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4243873001
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4231901890
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon closed pull request #62409: [fix](variant) normalize legacy single-part dot-key subcolumn paths on read
URL: https://github.com/apache/doris/pull/62409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4277512526
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4231901828
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4236473332
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (25/25)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62409_06bb9c6134c023f7e96b5ddfa37801ebc117c80a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 63.22% (23512/37190) |
| Line Coverage | 46.76% (241351/516160) |
| Region Coverage | 43.72% (197581/451879) |
| Branch Coverage | 45.03% (85592/190058) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3071601522
##########
be/src/util/json/path_in_data.cpp:
##########
@@ -224,6 +224,36 @@ PathInData PathInData::copy_pop_back() const {
return new_path;
}
+void PathInData::normalize_legacy_flat_dot_key() {
Review Comment:
生成迭代器的时候处理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4243842795
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4243873531
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 closed pull request #62409: [fix](variant) normalize legacy single-part dot-key subcolumn paths on read
URL: https://github.com/apache/doris/pull/62409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3073012321
##########
be/src/storage/segment/variant/variant_column_reader.cpp:
##########
@@ -1205,6 +1205,10 @@ Status VariantColumnReader::init(const ColumnReaderOptions& opts, ColumnMetaAcce
_statistics->subcolumns_non_null_size.emplace(relative_path.get_path(),
column_pb.none_null_size());
}
+ // 3.1.2 may store a flat JSON key like {"a.b": 1} as a single PathInData part.
+ // New compaction schema and query path expect a dot-split multi-part shape.
+ // Normalize here before inserting into the meta tree to match that shape.
+ relative_path.normalize_legacy_flat_dot_key();
Review Comment:
relative_path = PathInData(relative_path.get_path()); 这样可以吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4277482194
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4234318779
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #62409:
URL: https://github.com/apache/doris/pull/62409#discussion_r3071598149
##########
be/src/util/json/path_in_data.cpp:
##########
@@ -224,6 +224,36 @@ PathInData PathInData::copy_pop_back() const {
return new_path;
}
+void PathInData::normalize_legacy_flat_dot_key() {
Review Comment:
能在查询侧处理吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4243964545
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4243965633
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](variant) normalize legacy single-part dot-key subcolumn paths on read [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62409:
URL: https://github.com/apache/doris/pull/62409#issuecomment-4245067274
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (3/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62409_c6d098281049527f78bef655fb5d32bdbfa3ec6a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62409_c6d098281049527f78bef655fb5d32bdbfa3ec6a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.62% (27394/37208) |
| Line Coverage | 57.28% (295863/516491) |
| Region Coverage | 54.58% (246816/452210) |
| Branch Coverage | 56.18% (106845/190198) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org