You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/04/01 00:53:26 UTC
[GitHub] [hive] prasanthj opened a new pull request #966: HIVE-23118: Option
for exposing compile time counters as tez counters
prasanthj opened a new pull request #966: HIVE-23118: Option for exposing compile time counters as tez counters
URL: https://github.com/apache/hive/pull/966
TezCounters currently are runtime only. Some compile time information from optimizer can be exposed as counters which can then be used by workload management to make runtime decisions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] prasanthj commented on a change in pull request #966:
HIVE-23118: Option for exposing compile time counters as tez counters
Posted by GitBox <gi...@apache.org>.
prasanthj commented on a change in pull request #966: HIVE-23118: Option for exposing compile time counters as tez counters
URL: https://github.com/apache/hive/pull/966#discussion_r402646605
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
##########
@@ -185,6 +188,12 @@ public int monitorExecution() {
if (wmContext != null) {
Set<String> desiredCounters = wmContext.getSubscribedCounters();
TezCounters dagCounters = status.getDAGCounters();
+ // if initial counters exists, merge it with dag counters to get aggregated view
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #966:
HIVE-23118: Option for exposing compile time counters as tez counters
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #966: HIVE-23118: Option for exposing compile time counters as tez counters
URL: https://github.com/apache/hive/pull/966#discussion_r402615414
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java
##########
@@ -185,6 +188,12 @@ public int monitorExecution() {
if (wmContext != null) {
Set<String> desiredCounters = wmContext.getSubscribedCounters();
TezCounters dagCounters = status.getDAGCounters();
+ // if initial counters exists, merge it with dag counters to get aggregated view
Review comment:
Can we move this if block to a utility static function `mergeCounters`? It seems it is repeated in a couple of places, may be useful in other cases in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org