You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/07 14:29:49 UTC
[GitHub] [cordova-electron] erisu opened a new pull request #183: fix(npm): change prepack script to prepare
erisu opened a new pull request #183:
URL: https://github.com/apache/cordova-electron/pull/183
### Motivation, Context & Description
Use `prepare` hook-script instead of `prepack`.
While `prepack` works, `prepare` covers an important case that is needed when installing via `git` or `local`.
#### npm hook-scripts differences
> **prepack**
>
> * Runs BEFORE a tarball is packed (on "npm pack", "npm publish", and when installing a git dependencies).
> * NOTE: "npm run pack" is NOT the same as "npm pack". "npm run pack" is an arbitrary user defined script name, where as, "npm pack" is a CLI defined command.
> **prepare** (since `npm@4.0.0`)
>
> * Runs BEFORE the package is packed
> * Runs BEFORE the package is published
> * Runs on local npm install without any arguments
> * Run AFTER prepublish, but BEFORE prepublishOnly
> * NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.
The additional important cases that needs to be covered which `prepare` covers is.
> * Runs on local npm install without any arguments
and
> * NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.
### Testing
- `npm t`
- `npm pack`
- `npm install <git>`
- `npm install <local>`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #183: fix(npm): change prepack script to prepare
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #183:
URL: https://github.com/apache/cordova-electron/pull/183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io edited a comment on pull request #183: fix(npm): change prepack script to prepare
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #183:
URL: https://github.com/apache/cordova-electron/pull/183#issuecomment-756151078
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=h1) Report
> Merging [#183](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=desc) (497173b) into [master](https://codecov.io/gh/apache/cordova-electron/commit/b2617a94d4a8a859454850054d2b87748ec957e8?el=desc) (b2617a9) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 652
=========================================
Hits 652 652
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=footer). Last update [b2617a9...497173b](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io commented on pull request #183: fix(npm): change prepack script to prepare
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #183:
URL: https://github.com/apache/cordova-electron/pull/183#issuecomment-756151078
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=h1) Report
> Merging [#183](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=desc) (497173b) into [master](https://codecov.io/gh/apache/cordova-electron/commit/b2617a94d4a8a859454850054d2b87748ec957e8?el=desc) (b2617a9) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 652
=========================================
Hits 652 652
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=footer). Last update [b2617a9...497173b](https://codecov.io/gh/apache/cordova-electron/pull/183?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #183: fix(npm): change prepack script to prepare
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #183:
URL: https://github.com/apache/cordova-electron/pull/183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org