You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Rob Berens (JIRA)" <ji...@apache.org> on 2006/03/23 11:12:59 UTC
[jira] Created: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
[PATCH] Forms page styling: Added event handling for group of type choice
--------------------------------------------------------------------------
Key: COCOON-1809
URL: http://issues.apache.org/jira/browse/COCOON-1809
Project: Cocoon
Type: Improvement
Components: Blocks: Forms
Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
Reporter: Rob Berens
Priority: Minor
Attachments: forms-page-styling.txt
In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Rob Berens (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=comments#action_12372935 ]
Rob Berens commented on COCOON-1809:
------------------------------------
I see, what you meant.
I have tried your patch 20060403-cocoon-forms-1809. It looks a lot nicer, because you avoid to code the same thing twice. It doesn't work however. It fails with the message:
SystemID: resource://org/apache/cocoon/forms/resources/forms-page-styling.xsl; Line#: 182; Column#: 62
javax.xml.transform.TransformerException: Could not find variable with the name of id
The reason is that the variable id is not available in the context of the template formsOnShow. I suppose the same applies to the fi:items/fi:* path that is used in the template.
So might be we have to take my version in the end..
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=comments#action_12372933 ]
Jean-Baptiste Quenot commented on COCOON-1809:
----------------------------------------------
Sorry, what I meant is: could you please revert your changes and try my patch, called 20060403-cocoon-forms-1809. The only change from your patch is to avoid copy-paste between rendering of "tabs" and "choice".
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Jean-Baptiste Quenot closed COCOON-1809:
----------------------------------------
Fix Version: 2.2-dev (Current SVN)
2.1.9-dev (current SVN)
Resolution: Fixed
Committed, thanks!
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Fix For: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Rob Berens (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Rob Berens updated COCOON-1809:
-------------------------------
Attachment: forms-page-styling.xsl
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Jean-Baptiste Quenot updated COCOON-1809:
-----------------------------------------
Attachment: 20060403-cocoon-forms-1809
Could you please "svn revert" src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-page-styling.xsl and apply the attached patch? If it looks good, I can commit this.
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Jean-Baptiste Quenot updated COCOON-1809:
-----------------------------------------
Attachment: 20060403-cocoon-forms-1809
Could you please try again with this new patch?
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Jean-Baptiste Quenot reassigned COCOON-1809:
--------------------------------------------
Assign To: Jean-Baptiste Quenot
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: forms-page-styling.txt
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=all ]
Jean-Baptiste Quenot updated COCOON-1809:
-----------------------------------------
Attachment: (was: 20060403-cocoon-forms-1809)
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Rob Berens (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=comments#action_12372946 ]
Rob Berens commented on COCOON-1809:
------------------------------------
The new patch works fine! Thanks!
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1809) [PATCH] Forms page styling: Added
event handling for group of type choice
Posted by "Rob Berens (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/COCOON-1809?page=comments#action_12372932 ]
Rob Berens commented on COCOON-1809:
------------------------------------
I have added the reverted version with the patch applied.
> [PATCH] Forms page styling: Added event handling for group of type choice
> -------------------------------------------------------------------------
>
> Key: COCOON-1809
> URL: http://issues.apache.org/jira/browse/COCOON-1809
> Project: Cocoon
> Type: Improvement
> Components: Blocks: Forms
> Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN)
> Reporter: Rob Berens
> Assignee: Jean-Baptiste Quenot
> Priority: Minor
> Attachments: 20060403-cocoon-forms-1809, forms-page-styling.txt, forms-page-styling.xsl
>
> In forms-page-styling.xsl also a group of the type chois must implement event handling i.e. for the choice elements it must be possible to have an attribute formsOnShow containing some javascript to be executed.
> The attached patch makes this possible.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira