You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by th...@apache.org on 2020/09/29 13:50:13 UTC

[tapestry-5] branch 5.6.x updated (88bbca2 -> 010f32f)

This is an automated email from the ASF dual-hosted git repository.

thiagohp pushed a change to branch 5.6.x
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git.


    from 88bbca2  5.6.1 release
     new c306db4  Bumping version after release
     new 010f32f  TAP5-2643: NPE in Label when corresponding form field isn't rendered

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 build.gradle                                                   |  2 +-
 .../java/org/apache/tapestry5/corelib/components/Label.java    | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)


[tapestry-5] 02/02: TAP5-2643: NPE in Label when corresponding form field isn't rendered

Posted by th...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

thiagohp pushed a commit to branch 5.6.x
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git

commit 010f32ff763b72bc28c278016aa8148bba9d40a9
Author: Thiago H. de Paula Figueiredo <th...@arsmachina.com.br>
AuthorDate: Tue Sep 29 10:49:54 2020 -0300

    TAP5-2643: NPE in Label when corresponding form field isn't rendered
---
 .../java/org/apache/tapestry5/corelib/components/Label.java    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
index bc3fa8d..dd153b3 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
@@ -118,9 +118,13 @@ public class Label
         labelElement.attribute("id", id);
         labelElement.forceAttributes("for", fieldId);
         
-        Element input = labelElement.getDocument().getElementById(field.getClientId());
-        if (input != null) {
-            input.attribute("aria-labelledby", id);
+        if (fieldId != null)
+        {
+            Element input = labelElement.getDocument().getElementById(field.getClientId());
+            if (input != null) 
+            {
+                input.attribute("aria-labelledby", id);
+            }
         }
         
         decorator.insideLabel(field, labelElement);


[tapestry-5] 01/02: Bumping version after release

Posted by th...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

thiagohp pushed a commit to branch 5.6.x
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git

commit c306db444888e53fb9a1ab39736726112852dfcc
Author: Thiago H. de Paula Figueiredo <th...@arsmachina.com.br>
AuthorDate: Tue Sep 29 10:46:57 2020 -0300

    Bumping version after release
---
 build.gradle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build.gradle b/build.gradle
index 11dfb36..1108948 100755
--- a/build.gradle
+++ b/build.gradle
@@ -33,7 +33,7 @@ project.version = tapestryVersion()
 
 def tapestryVersion() {
 
-    def major = "5.6.1"
+    def major = "5.6.2"
     def minor = ""
 
     // When building on the CI server, make sure -SNAPSHOT is appended, as it is a nightly build.