You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by chonton <gi...@git.apache.org> on 2018/05/19 01:36:17 UTC
[GitHub] commons-lang pull request #331: LANG-1380: FastDateParser too strict on abbr...
GitHub user chonton opened a pull request:
https://github.com/apache/commons-lang/pull/331
LANG-1380: FastDateParser too strict on abbreviated short month symbols
I'm interested in feedback. Particularly from recent committers - @garydgregory @britter @PascalSchumacher @sebbASF
thanks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chonton/commons-lang LANG-1380
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #331
----
commit 8c114fa865156fa4341390e66e42ca0cf3c494c8
Author: Chas Honton <ch...@...>
Date: 2018-05-19T01:29:26Z
LANG-1380: FastDateParser too strict on abbreviated short month symbols
----
---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/331
+1
---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Posted by chonton <gi...@git.apache.org>.
Github user chonton commented on the issue:
https://github.com/apache/commons-lang/pull/331
closed with commit f56931c176fef5e164b681c740746aebdccccec3
---
[GitHub] commons-lang pull request #331: LANG-1380: FastDateParser too strict on abbr...
Posted by chonton <gi...@git.apache.org>.
Github user chonton closed the pull request at:
https://github.com/apache/commons-lang/pull/331
---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/331
@chonton No further review comments by anyone, so I guess this is good to merge?
---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Posted by sebbASF <gi...@git.apache.org>.
Github user sebbASF commented on the issue:
https://github.com/apache/commons-lang/pull/331
The change is hard to review as it contains at least one unrelated change and some code re-arrangement.
Would it be possible to provide a PR that addresses only the proposed change?
---
[GitHub] commons-lang issue #331: LANG-1380: FastDateParser too strict on abbreviated...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/331
[](https://coveralls.io/builds/17069311)
Coverage decreased (-0.004%) to 95.229% when pulling **b09d26f12bd4bfd1456d876f56fb8d6986a88a26 on chonton:LANG-1380** into **09ef69c5b51115300da6df43690cd455d83c8027 on apache:master**.
---