You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Naros <gi...@git.apache.org> on 2015/06/20 20:23:22 UTC
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
GitHub user Naros opened a pull request:
https://github.com/apache/struts/pull/43
WW-4516: Allow JSON plug-in to skip bean cache when devMode is enabled.
Adds support for disabling bean cache on JSON plugin when devMode is enabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Naros/struts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 30df43f1fa01ecbbc021d47cadb3cd759bdba8f9
Author: Naros <cr...@gmail.com>
Date: 2015-06-20T18:19:29Z
WW-4516: Allow JSON plug-in to skip bean cache when devMode is enabled.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by Naros <gi...@git.apache.org>.
Github user Naros commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32938705
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java ---
@@ -92,12 +96,18 @@
private String contentType;
private String wrapPrefix;
private String wrapSuffix;
-
+ private boolean debugMode = false;
--- End diff --
Changed in latest commits per your request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32937264
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java ---
@@ -53,7 +68,22 @@
* @throws JSONException
*/
public static String serialize(Object object) throws JSONException {
--- End diff --
Throw away and use the new version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32905325
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java ---
@@ -53,7 +68,22 @@
* @throws JSONException
*/
public static String serialize(Object object) throws JSONException {
--- End diff --
Is this method used somewhere else? If not, it's the perfect time to drop it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by Naros <gi...@git.apache.org>.
Github user Naros commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32936125
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java ---
@@ -53,7 +68,22 @@
* @throws JSONException
*/
public static String serialize(Object object) throws JSONException {
--- End diff --
It is currently used in the test cases
JSONResultTest - testJSONUtilNPEOnNullMethod()
JSONUtilTest = testSerializeDeserialize()
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by Naros <gi...@git.apache.org>.
Github user Naros commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32930991
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONUtil.java ---
@@ -53,7 +68,22 @@
* @throws JSONException
*/
public static String serialize(Object object) throws JSONException {
--- End diff --
Not that I can see from just scanning my github fork. I'll double check when I get home tonight and if not; I'll remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32939393
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java ---
@@ -92,12 +96,18 @@
private String contentType;
private String wrapPrefix;
private String wrapSuffix;
-
+ private boolean devMode = false;
+
@Inject(StrutsConstants.STRUTS_I18N_ENCODING)
public void setDefaultEncoding(String val) {
this.defaultEncoding = val;
}
-
+
+ @Inject(StrutsConstants.STRUTS_DEVMODE)
+ public void setDebugMode(String val) {
--- End diff --
Can you rename setter as well? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/43#discussion_r32905222
--- Diff: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java ---
@@ -92,12 +96,18 @@
private String contentType;
private String wrapPrefix;
private String wrapSuffix;
-
+ private boolean debugMode = false;
--- End diff --
Please rename this to `devMode`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4516: Allow JSON plug-in to skip bean cach...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org