[GitHub] [airflow] Taragolis commented on a diff in pull request #29581: AWS system test sagemaker-endpoint: archive logs

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #29581:
URL: https://github.com/apache/airflow/pull/29581#discussion_r1109696047


##########
tests/system/providers/amazon/aws/example_sagemaker_endpoint.py:
##########
@@ -88,6 +88,11 @@ def delete_endpoint(endpoint_name):
     boto3.client("sagemaker").delete_endpoint(EndpointName=endpoint_name)
 
 
+@task(trigger_rule=TriggerRule.ALL_DONE)
+def archive_logs(log_group_name):
+    boto3.client("logs").put_retention_policy(logGroupName=log_group_name, retentionInDays=1)

Review Comment:
   Is 1 day would be enough? In some previous PR which also related to retention period for CloudWatch logs in system tests (can't find it quick) we decide as far a i remember 14 days
   
   More expensive it write Gigabytes/Terabytes of logs rather than store it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org