[GitHub] klion26 commented on a change in pull request #7726: [FLINK-10342] Filter restored partitions with discovered partitions b…

[GitBox <gi...@apache.org>]

klion26 commented on a change in pull request #7726: [FLINK-10342] Filter restored partitions with discovered partitions b…
URL: https://github.com/apache/flink/pull/7726#discussion_r257587838
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ##########
 @@ -138,6 +138,14 @@
 	 */
 	private boolean enableCommitOnCheckpoints = true;
 
+	/**
+	 * User-set flag to disable filter restored partitions with current
+	 * discovered partitions. It's enabled by default since it'll result unexpected
+	 * behaviors - e.g. When changing the topic name, or remove some topics,
+	 * The removed/renamed partitions will be still consumed.
+	 */
+	private boolean filterRestoredPartitionsWithDiscovered = true;
 
 Review comment:
   If we make `true` as default value, is the behavior different from previous?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services