You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/15 14:17:00 UTC
[jira] [Commented] (DRILL-8044) Remove/Update contrib/storage-hive copy of log4j Strings.java
[ https://issues.apache.org/jira/browse/DRILL-8044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443839#comment-17443839 ]
ASF GitHub Bot commented on DRILL-8044:
---------------------------------------
pjfanning commented on pull request #2375:
URL: https://github.com/apache/drill/pull/2375#issuecomment-968952893
@cgivre You reported the initial issue - would you be able to try this out with a POI 5.1.0 (and excel-streaming-reader 3.2.3)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove/Update contrib/storage-hive copy of log4j Strings.java
> -------------------------------------------------------------
>
> Key: DRILL-8044
> URL: https://issues.apache.org/jira/browse/DRILL-8044
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Hive
> Affects Versions: 1.19.0
> Reporter: PJ Fanning
> Priority: Major
>
> [https://github.com/apache/drill/blob/master/contrib/storage-hive/core/src/main/java/org/apache/logging/log4j/util/Strings.java] is a copy of the real Log4j class but causes issues for Apache POI Excel code that relies on the latest Log4j code.
> Apache POI started using log4j 2.x in POI 5.1.0.
> This issue was originally reported at https://github.com/apache/drill/issues/2373
>
> *Describe the solution you'd like*
> If this class is really necessary, could you consider updating it to match the latest Log4j code? As long as Drill keeps its own copy of this Strings class, it is likely to regularly hit issues with being incompatible with latest log4j releases.
> https://issues.apache.org/jira/browse/HIVE-23088 is marked as fixed in recent Hive releases - so ideally, Drill team should remove the copy of the Strings class in Drill contrib/storage-hive. I can only find Hive 3.1.2 in Maven Central (this doesn't have the HIVE-23088 fix) - so I'm not really sure what Apache Hive team are doing with the release numbers.
> If you really need to keep the copy of the log4j Strings class, the latest log4j release code seems safe in that it is self-contained (other than using core Java code).
> [https://github.com/apache/logging-log4j2/blob/rel/2.14.1/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)