You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/24 03:44:40 UTC

[GitHub] [kylin] xiacongling opened a new pull request #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

xiacongling opened a new pull request #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167
 
 
   ## Proposed changes
   This PR fix the bug described in [KYLIN-4432](https://issues.apache.org/jira/browse/KYLIN-4432) that duplicated queries with sytax error take unexpect long time when lazy query enabled. 
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature works
   - [x] If this change need a document change, I will prepare another pr against the `document` branch
   - [x] Any dependent changes have been merged
   
   ## Further comments
   N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-603004492
 
 
   ## Pull Request Test Coverage Report for [Build 5798](https://coveralls.io/builds/29730364)
   
   * **0** of **11**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **422** unchanged lines in **15** files lost coverage.
   * Overall coverage decreased (**-0.05%**) to **27.473%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29730364/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L468) | 0 | 11 | 0.0%
   <!-- | **Total:** | **0** | **11** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29730364/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/29730364/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L85) | 1 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29730364/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L477) | 1 | 0% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/29730364/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java](https://coveralls.io/builds/29730364/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FMapReduceExecutable.java#L496) | 3 | 14.76% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29730364/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java](https://coveralls.io/builds/29730364/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FDiagnosisService.java#L102) | 5 | 32.14% |
   | [core-cube/src/main/java/org/apache/kylin/cube/common/SegmentPruner.java](https://coveralls.io/builds/29730364/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcommon%2FSegmentPruner.java#L60) | 9 | 69.23% |
   | [core-common/src/main/java/org/apache/kylin/common/util/ToolUtil.java](https://coveralls.io/builds/29730364/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FToolUtil.java#L38) | 18 | 21.28% |
   | [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/29730364/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L85) | 40 | 18.45% |
   <!-- | **Total:** | **422** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29730364/badge)](https://coveralls.io/builds/29730364) |
   | :-- | --: |
   | Change from base [Build 5776](https://coveralls.io/builds/29463823): |  -0.05% |
   | Covered Lines: | 24314 |
   | Relevant Lines: | 88502 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-606395415
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=h1) Report
   > Merging [#1167](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1167      +/-   ##
   ============================================
   - Coverage     25.06%   25.01%   -0.06%     
   - Complexity     6250     6253       +3     
   ============================================
     Files          1446     1449       +3     
     Lines         88309    88502     +193     
     Branches      12358    12374      +16     
   ============================================
     Hits          22136    22136              
   - Misses        64003    64189     +186     
   - Partials       2170     2177       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=) | `58.46% <0.00%> (-4.04%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
   | [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.91% <0.00%> (-0.42%)` | `6.00% <0.00%> (ø%)` | |
   | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | `1.53% <0.00%> (-0.04%)` | `2.00% <0.00%> (ø%)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9Kb2JEaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <0.00%> (ø)` | `10.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/kylin/metrics/MetricsManager.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL01ldHJpY3NNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [26 more](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=footer). Last update [734a997...7034a04](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-606378932
 
 
   @kyotoYaho Thanks for the suggestion. I updated the PR with a finally block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] zhangayqian commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-604842794
 
 
   Verified.
   In kylin 3.0.1，KYLIN-4432 could be reproduce.
   <img width="1019" alt="image" src="https://user-images.githubusercontent.com/31064237/77729107-d7d8a380-7038-11ea-9161-1f7198f0e5e9.png">
   <img width="1059" alt="image" src="https://user-images.githubusercontent.com/31064237/77729240-225a2000-7039-11ea-8107-31a2307000fd.png">
   
   Add this PR will fix.
   
   <img width="996" alt="image" src="https://user-images.githubusercontent.com/31064237/77729564-ed9a9880-7039-11ea-91b4-71072cde5f2b.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
kyotoYaho edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-604873864
 
 
   LGTM. How about extract the dummy response logic to the finally block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-603004492
 
 
   ## Pull Request Test Coverage Report for [Build 5783](https://coveralls.io/builds/29569703)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **8** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.003%**) to **27.517%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29569703/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L468) | 0 | 6 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29569703/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29569703/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29569703/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   <!-- | **Total:** | **8** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29569703/badge)](https://coveralls.io/builds/29569703) |
   | :-- | --: |
   | Change from base [Build 5776](https://coveralls.io/builds/29463823): |  -0.003% |
   | Covered Lines: | 24301 |
   | Relevant Lines: | 88312 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
kyotoYaho edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-604873864
 
 
   LGTM. How about extract evicting the dummy response logic to the finally block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-603004492
 
 
   ## Pull Request Test Coverage Report for [Build 5807](https://coveralls.io/builds/29774583)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **387** unchanged lines in **13** files lost coverage.
   * Overall coverage decreased (**-0.05%**) to **27.475%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/29774583/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L468) | 0 | 6 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/29774583/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L85) | 1 | 0% |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java](https://coveralls.io/builds/29774583/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FMapReduceExecutable.java#L496) | 3 | 14.76% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29774583/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java](https://coveralls.io/builds/29774583/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FDiagnosisService.java#L102) | 5 | 32.14% |
   | [core-cube/src/main/java/org/apache/kylin/cube/common/SegmentPruner.java](https://coveralls.io/builds/29774583/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcommon%2FSegmentPruner.java#L60) | 9 | 69.23% |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/MetricsManager.java](https://coveralls.io/builds/29774583/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2FMetricsManager.java#L96) | 14 | 0% |
   | [core-common/src/main/java/org/apache/kylin/common/util/ToolUtil.java](https://coveralls.io/builds/29774583/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FToolUtil.java#L38) | 18 | 21.28% |
   | [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/29774583/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L85) | 40 | 18.45% |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java](https://coveralls.io/builds/29774583/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FCubingJob.java#L264) | 40 | 1.53% |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/29774583/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L320) | 41 | 42.16% |
   <!-- | **Total:** | **387** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29774583/badge)](https://coveralls.io/builds/29774583) |
   | :-- | --: |
   | Change from base [Build 5776](https://coveralls.io/builds/29463823): |  -0.05% |
   | Covered Lines: | 24316 |
   | Relevant Lines: | 88502 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
kyotoYaho commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-604873864
 
 
   LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
xiacongling commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-607122057
 
 
   Never mind, @kyotoYaho ! I think the problem is that conditions are lost in finally block. We can either rebuild the conditions or use the cached value.
   
   - The former solution will add complicated condition checks in the final block. These checks are difficult to understand and test, and may be buggy in the future when features are addd or improvements are made. 
   - The latter will visit the cache one more time and will reduce the query performance.
   
   Using "try .. finally" is more elegant, but some code refactoring is needed to keep it clean, I think. To get out of the dilemma, we can treat this PR as a quick bug-fix, and discuss the refactoring in another issue. 
   
   I will revert the commit. Thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-606395415
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=h1) Report
   > Merging [#1167](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/734a997a05bee7b722010b177ec0cce8494bcd1d&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1167      +/-   ##
   ============================================
   - Coverage     25.06%   25.00%   -0.07%     
   - Complexity     6250     6251       +1     
   ============================================
     Files          1446     1449       +3     
     Lines         88309    88502     +193     
     Branches      12358    12375      +17     
   ============================================
   - Hits          22136    22131       -5     
   - Misses        64003    64191     +188     
   - Partials       2170     2180      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...va/org/apache/kylin/cube/common/SegmentPruner.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9TZWdtZW50UHJ1bmVyLmphdmE=) | `58.46% <0.00%> (-4.04%)` | `26.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
   | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `65.65% <0.00%> (-1.02%)` | `21.00% <0.00%> (-1.00%)` | |
   | [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.91% <0.00%> (-0.42%)` | `6.00% <0.00%> (ø%)` | |
   | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | `1.53% <0.00%> (-0.04%)` | `2.00% <0.00%> (ø%)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [28 more](https://codecov.io/gh/apache/kylin/pull/1167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=footer). Last update [734a997...8150221](https://codecov.io/gh/apache/kylin/pull/1167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] kyotoYaho commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled

Posted by GitBox <gi...@apache.org>.
kyotoYaho commented on issue #1167: KYLIN-4432 duplicated queries with sytax error take unexpect long time when lazy query enabled
URL: https://github.com/apache/kylin/pull/1167#issuecomment-606990556
 
 
   Hi xiacongling, the previous one without finally block is better. I'm sorry I mislead you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services