You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/11 19:16:05 UTC
[GitHub] [iceberg] rdblue opened a new pull request, #5249: Core: Fix wrapper performance for delete filters
rdblue opened a new pull request, #5249:
URL: https://github.com/apache/iceberg/pull/5249
This is an alternative implementation of #5242 and #5244. Rather than adding factory classes, this adds a `copyFor` method to `StructLikeWrapper` and `InternalRecordWrapper`. This is smaller than adding a factory and keeps the logic in one place (rather than duplicating it in a factory).
This updates cases where the wrappers are used to copy wrappers rather than create new ones. This avoids analyzing the type that the wrappers are created for and should speed up execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5249: Core: Fix wrapper performance for delete filters
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5249:
URL: https://github.com/apache/iceberg/pull/5249#issuecomment-1180911192
Thanks, @aokolnychyi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5249: Core: Fix wrapper performance for delete filters
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5249:
URL: https://github.com/apache/iceberg/pull/5249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org