You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/07 01:13:49 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38139: [SPARK-40693] mypy complains accessing the variable defined in the class method.
amaliujia opened a new pull request, #38139:
URL: https://github.com/apache/spark/pull/38139
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
For SparkConnectTestsPlanOnly, those unit tests access the mock remote session by `self.connect`, how mypy complains in as `error: "SparkConnectTestsPlanOnly" has no attribute "connect" [attr-defined]`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix mypy.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Mypy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38139: [SPARK-40693] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1270979530
Another way to fix is to define the `connect` explicitly as
```
class SparkConnectSQLTestCase(ReusedPySparkTestCase):
"""Parent test fixture class for all Spark Connect related
test cases."""
connect: RemoteSparkSession
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38139:
URL: https://github.com/apache/spark/pull/38139#discussion_r989616810
##########
python/pyspark/testing/connectutils.py:
##########
@@ -57,5 +57,7 @@ def __getattr__(self, item: str) -> Any:
class PlanOnlyTestFixture(unittest.TestCase):
@classmethod
def setUpClass(cls: Any) -> None:
- cls.connect = MockRemoteSession()
+ cls._connect = MockRemoteSession()
Review Comment:
```suggestion
cls.connect = MockRemoteSession()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38139:
URL: https://github.com/apache/spark/pull/38139#discussion_r989630740
##########
python/pyspark/testing/connectutils.py:
##########
@@ -57,5 +57,7 @@ def __getattr__(self, item: str) -> Any:
class PlanOnlyTestFixture(unittest.TestCase):
@classmethod
def setUpClass(cls: Any) -> None:
- cls.connect = MockRemoteSession()
+ cls._connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+
+ connect: "MockRemoteSession"
Review Comment:
ah sure looks like we want to keep with the existing styple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38139:
URL: https://github.com/apache/spark/pull/38139#discussion_r989595062
##########
python/pyspark/testing/connectutils.py:
##########
@@ -57,5 +57,8 @@ def __getattr__(self, item: str) -> Any:
class PlanOnlyTestFixture(unittest.TestCase):
@classmethod
def setUpClass(cls: Any) -> None:
- cls.connect = MockRemoteSession()
+ cls._connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+
+ def connect(self) -> "MockRemoteSession":
Review Comment:
Should probably a property instead of a method. Let's do it with `connect: RemoteSparkSession` I think that's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38139:
URL: https://github.com/apache/spark/pull/38139#discussion_r989617237
##########
python/pyspark/testing/connectutils.py:
##########
@@ -57,5 +57,7 @@ def __getattr__(self, item: str) -> Any:
class PlanOnlyTestFixture(unittest.TestCase):
@classmethod
def setUpClass(cls: Any) -> None:
- cls.connect = MockRemoteSession()
+ cls._connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+
+ connect: "MockRemoteSession"
Review Comment:
Let's put this type hint under `class PlanOnlyTestFixture` (see https://github.com/apache/spark/blob/master/python/pyspark/sql/tests/test_connect_basic.py#L34)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1271038128
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1271028496
https://github.com/amaliujia/spark/actions/runs/3201742847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1270990684
which mypy version do you use BTW? It's interesting that they all pass in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38139: [SPARK-40693] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1270981297
Here is the build job: https://github.com/amaliujia/spark/actions/runs/3201556386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1270991536
@HyukjinKwon
I just used `./dev/lint-python`. I happened to add a new unit test here and my code contains `self.connect` (as the same other tests) and mypy complains on my line of the code only. I am guessing mypy is triggered only for a new change somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38139: [SPARK-40693] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38139:
URL: https://github.com/apache/spark/pull/38139#issuecomment-1270981503
R: @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38139: [SPARK-40693][CONNECT] mypy complains accessing the variable defined in the class method.
URL: https://github.com/apache/spark/pull/38139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org