You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/02/09 17:42:16 UTC
Review Request 43363: GEODE-946: Source and javadoc artifacts from
modules have inconsistent locations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43363/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Dan Smith.
Repository: geode
Description
-------
GEODE-946: Source and javadoc artifacts from modules have inconsistent locations
Diffs
-----
gradle/java.gradle 758420dab12d839986bdfad84651dba400b6caf5
Diff: https://reviews.apache.org/r/43363/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 43363: GEODE-946: Source and javadoc artifacts from
modules have inconsistent locations
Posted by Jens Deppe <jd...@pivotal.io>.
> On Feb. 9, 2016, 4:48 p.m., Anthony Baker wrote:
> > gradle/java.gradle, line 91
> > <https://reviews.apache.org/r/43363/diff/1/?file=1238480#file1238480line91>
> >
> > I wonder if this should use the `gradle.taskGraph.whenReady` callback to avoid configuration ordering problems.
I tried that, but I think it's the wrong approach as, at that point, some tasks (gemfire-core:webJar for ex.) have already assigned a new baseName (and so things break as it gets overwritten). If I understand this Gradle "rule", it is applied whenever a new task is created/defined and thus allows for defaults to be assigned which can then be overwritten during actual task configuration.
- Jens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43363/#review118407
-----------------------------------------------------------
On Feb. 9, 2016, 4:42 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43363/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 4:42 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-946: Source and javadoc artifacts from modules have inconsistent locations
>
>
> Diffs
> -----
>
> gradle/java.gradle 758420dab12d839986bdfad84651dba400b6caf5
>
> Diff: https://reviews.apache.org/r/43363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 43363: GEODE-946: Source and javadoc artifacts from
modules have inconsistent locations
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43363/#review118407
-----------------------------------------------------------
gradle/java.gradle (line 91)
<https://reviews.apache.org/r/43363/#comment179631>
I wonder if this should use the `gradle.taskGraph.whenReady` callback to avoid configuration ordering problems.
- Anthony Baker
On Feb. 9, 2016, 4:42 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43363/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 4:42 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-946: Source and javadoc artifacts from modules have inconsistent locations
>
>
> Diffs
> -----
>
> gradle/java.gradle 758420dab12d839986bdfad84651dba400b6caf5
>
> Diff: https://reviews.apache.org/r/43363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>