You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/11 21:14:42 UTC

[GitHub] [pulsar] zzzming opened a new pull request #9178: upgrade presto version to 334

zzzming opened a new pull request #9178:
URL: https://github.com/apache/pulsar/pull/9178


   ### Motivation
   
   Upgrade Presto to 334 that is required in preparation to run on JDK 11, although this PR does not source and target JDK still at 1.8.
   
   ### Modifications
   
   Presto 334 also changes the Main class to a new package and class in a new jar, presto-server-main.jar. It has minor changes to required properties. Its dependency common-langs3 is also required to be upgraded to 3.9 to work in both JDK1.8 and 11.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zzzming commented on pull request #9178: upgrade presto version to 334 for JDK 11

Posted by GitBox <gi...@apache.org>.
zzzming commented on pull request #9178:
URL: https://github.com/apache/pulsar/pull/9178#issuecomment-758254429


   I checked Presto334 is only for JDK11. I can do another PR to compile and support JDK11 with other changes. This PR will be closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zzzming closed pull request #9178: upgrade presto version to 334 for JDK 11

Posted by GitBox <gi...@apache.org>.
zzzming closed pull request #9178:
URL: https://github.com/apache/pulsar/pull/9178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org