You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Karthik Kambatla (JIRA)" <ji...@apache.org> on 2012/08/14 20:45:37 UTC

[jira] [Created] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Karthik Kambatla created MAPREDUCE-4556:
-------------------------------------------

             Summary: FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
                 Key: MAPREDUCE-4556
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
          Components: contrib/fair-share
    Affects Versions: 1.0.3
            Reporter: Karthik Kambatla
            Assignee: Karthik Kambatla
            Priority: Minor




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karthik Kambatla updated MAPREDUCE-4556:
----------------------------------------

    Attachment: MR-4556.patch

Rebased on branch-1. 

Testing:
{{TestFairScheduler#testPoolAssignment()}} and {{TestFairScheduler#testSetPoolTwice()}} verify {{PoolSchedulable#updateDemand()}} that the patch changes.

However, a couple of other tests fail in {{TestFairScheduler}}. Will create a JIRA for those failures.
                
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch, MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karthik Kambatla updated MAPREDUCE-4556:
----------------------------------------

    Attachment: MR-4556.patch
    
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MAPREDUCE-4556 started by Karthik Kambatla.

> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated MAPREDUCE-4556:
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks Karthik. Committed to branch-1.
                
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: MR-4556.patch, MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434638#comment-13434638 ] 

Hadoop QA commented on MAPREDUCE-4556:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12540965/MR-4556.patch
  against trunk revision .

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2727//console

This message is automatically generated.
                
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Karthik Kambatla (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karthik Kambatla updated MAPREDUCE-4556:
----------------------------------------

    Status: Patch Available  (was: In Progress)
    
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469793#comment-13469793 ] 

Alejandro Abdelnur commented on MAPREDUCE-4556:
-----------------------------------------------

+1 pending on YARN-23 to get in trunk.
                
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch, MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4556) FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450305#comment-13450305 ] 

Hadoop QA commented on MAPREDUCE-4556:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544157/MR-4556.patch
  against trunk revision .

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2827//console

This message is automatically generated.
                
> FairScheduler: PoolSchedulable#updateDemand() has potential redundant computation
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4556
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4556
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: MR-4556.patch, MR-4556.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira