[GitHub] sijie closed pull request #1269: Close bookkeeper client used in format

[GitBox <gi...@apache.org>]

sijie closed pull request #1269: Close bookkeeper client used in format
URL: https://github.com/apache/bookkeeper/pull/1269
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
index d0078f41d..7671721d2 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
@@ -1160,8 +1160,9 @@ public static boolean format(ServerConfiguration conf,
                     return false;
                 }
 
-                BookKeeper bkc = new BookKeeper(new ClientConfiguration(conf));
-                bkc.ledgerManagerFactory.format(conf, bkc.getMetadataClientDriver().getLayoutManager());
+                try (BookKeeper bkc = new BookKeeper(new ClientConfiguration(conf))) {
+                    bkc.ledgerManagerFactory.format(conf, bkc.getMetadataClientDriver().getLayoutManager());
+                }
 
                 return rm.format();
             } catch (Exception e) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services