You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Karam Singh (JIRA)" <ji...@apache.org> on 2008/09/26 11:47:44 UTC

[jira] Created: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
-----------------------------------------------------------------------------------

                 Key: HADOOP-4288
                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
             Project: Hadoop Core
          Issue Type: Bug
          Components: contrib/capacity-sched
    Affects Versions: 0.19.0
            Reporter: Karam Singh


2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod K V updated HADOOP-4288:
------------------------------

    Remaining Estimate: 0h
     Original Estimate: 0h

At present, we limit users only by the particular user's total number of tasks and as such, numJobsByUser is not useful at all. Unless we wish to limit users by the number of jobs also in the future, we can altogether remove numJobsByUser. May or may not be in this patch though.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635303#action_12635303 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

It is unlikely that {{jobRemoved}} is called, due to the HADOOP-4053, unless the job retirement actually occurred. Karam should verify this, though. Irrespective of that, the bug you mention in {{jobAdded}} should be fixed. Likewise in {{jobRemoved}}.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated HADOOP-4288:
-------------------------------

    Attachment: HADOOP-4288-v4.patch

Adding a patch that incorporates Hemanth's comments. 
bq. The code adds a debug LOG statement that could print a null value of the variable i in 
+1.

bq. The test case does not seem to test that when job is removed, the associated structures are correctly cleaned up
The internal structures are not visible in the test case. Since this issue is about getting NPE when two jobs are submitted by the same user and one of them finishes, I have written the test case just to check if {{assignTasks()}} works when expected. If {{assignTasks}} works then I assume internal structures should be fine.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-4288:
--------------------------------

    Fix Version/s: 0.19.0

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634810#action_12634810 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

Can we have some more details on when this happens - the test scenario, etc. Because clearly it doesn't happen always.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635302#action_12635302 ] 

Amar Kamat commented on HADOOP-4288:
------------------------------------

I think something like this *might* have happened
1) User _user_ submitted a job, say _job1_
2) {{CapacityTaskScheduler.TaskSchedulingMgr.jobAdded()}} gets invoked. {{numJobs}} for _user_ is set to 1 and {{numRunningTasks}} is set to 0.
3) Another job was submitted by _user_, say _job2_. Because of a bug in {{CapacityTaskScheduler.TaskSchedulingMgr.jobAdded()}}, {{numJobs}} for _user_ will still be 1.
4) _job1_ completes and {{CapacityTaskScheduler.TaskSchedulingMgr.jobRemoved()}} is invoked. All entries for _user_ in {{numJobs}} and {{numRunningTasks}} gets removed.
5) Any update for _job2_ will result into NPE as {{numRunningTasks}} is missing an entry for _user_.

Karam, could you plz verify this using the following steps
1) Find out the job for which the error occured, look at the attempt for which the update was called.
2) Find out the user of the job, say $user.
3) Check if there were other jobs submitted by the same user and if they have finished
4) If in DEBUG mode, check if you see the following line
{code}
JOb to be removed for user $user
No more jobs for user, number of users
{code}

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635677#action_12635677 ] 

Vinod K V commented on HADOOP-4288:
-----------------------------------

bq. So, I think it is required to hold this structure.

Agreed. +1 for leaving it as is.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Karam Singh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635320#action_12635320 ] 

Karam Singh commented on HADOOP-4288:
-------------------------------------

Yes, "JOb to be removed for user $user "and "No more jobs for user, number of users" are pesrent in Jobtracker log. And problem occurs when there more than one jobs submiitted by same user and one job of the job is finished as pointed out by Amar.
Also I  was using path for Hadoop-4053 [this|https://issues.apache.org/jira/secure/attachment/12390257/HADOOP-4053-v1.patch] which internally calls jobRemoved 

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated HADOOP-4288:
-------------------------------

    Attachment: HADOOP-4288-v3.patch

Attaching a patch with the test case.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635663#action_12635663 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

bq. At present, we limit users only by the particular user's total number of tasks and as such, numJobsByUser is not useful at all.

We use number of jobs per user to compute limits. The computation of limit is as follows:
{code}
  int limit = Math.max((int)(Math.ceil((double)currentCapacity/
          (double)qsi.numJobsByUser.size())), 
          (int)(Math.ceil((double)(qsi.ulMin*currentCapacity)/100.0)));
{code}

So, I think it is required to hold this structure. Therefore, the patch also seems fine. But I think we need a unit test for this.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hemanth Yamijala updated HADOOP-4288:
-------------------------------------

    Priority: Blocker  (was: Major)

Promoting to a blocker based on current diagnosis. This is a clear bug in the code that will result in this error whenever users run more than one jobs, assuming HADOOP-4053 is fixed.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637369#action_12637369 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

Patch looks good to me. I agree on the explanation regarding the test case that the failure path is implicitly tested. 

Just note that when this goes in, the patch for HADOOP-4053 would need to change this test case to call {{jobUpdated}} rather than {{jobRemoved}}.



> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated HADOOP-4288:
-------------------------------

    Status: Patch Available  (was: Open)

Running through hudson.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637818#action_12637818 ] 

Amar Kamat commented on HADOOP-4288:
------------------------------------

_test-patch_ result
{code}
+1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

{code}


> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Karam Singh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634801#action_12634801 ] 

Karam Singh commented on HADOOP-4288:
-------------------------------------

Full Stack trace is  -:
2008-09-26 09:28:53,254 INFO org.apache.hadoop.ipc.Server: IPC Server handler 2 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@29d75, false, true, 99) from <ip:port>: error: java.io.IOException: java.lang.Nu
llPointerException
java.io.IOException: java.lang.NullPointerException
        at org.apache.hadoop.mapred.CapacityTaskScheduler$TaskSchedulingMgr.updateQSIObjects(CapacityTaskScheduler.java:503)
        at org.apache.hadoop.mapred.CapacityTaskScheduler$TaskSchedulingMgr.assignTasks(CapacityTaskScheduler.java:717)
        at org.apache.hadoop.mapred.CapacityTaskScheduler$TaskSchedulingMgr.access$1100(CapacityTaskScheduler.java:243)
        at org.apache.hadoop.mapred.CapacityTaskScheduler.assignTasks(CapacityTaskScheduler.java:1093)
        at org.apache.hadoop.mapred.JobTracker.heartbeat(JobTracker.java:1853)
        at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:452)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:888)



> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated HADOOP-4288:
-------------------------------

    Attachment: HADOOP-4288-v2.patch

Attaching a patch with more bug fixes.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch
>
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat reassigned HADOOP-4288:
----------------------------------

    Assignee: Amar Kamat

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638758#action_12638758 ] 

Hudson commented on HADOOP-4288:
--------------------------------

Integrated in Hadoop-trunk #630 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/630/])
    

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635327#action_12635327 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

Ah. So, the patch file currently uploaded for HADOOP-4053 was used. OK, then it makes sense. Was this patch also applied to the environment where HADOOP-4290 was found ?

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636997#action_12636997 ] 

Hemanth Yamijala commented on HADOOP-4288:
------------------------------------------

- The code adds a debug LOG statement that could print a null value of the variable {{i}} in {{CapacityTaskScheduler.jobAdded}}. This will not cause any problem, but will not give the right information (that there is 1 job for the user).
- The test case does not seem to test that when job is removed, the associated structures are correctly cleaned up. Isn't that what should be tested? Also, I think the test case can be named something more relevant like {{testJobRemoval}} or something like that.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637833#action_12637833 ] 

Amar Kamat commented on HADOOP-4288:
------------------------------------

Ran _ant test-contrib_ on my box. All tests passed except {{TestStreamingExitStatus}} which seems unrelated to this patch.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-4288:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Amar!

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch, HADOOP-4288-v2.patch, HADOOP-4288-v3.patch, HADOOP-4288-v4.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4288) java.lang.NullPointerException is observed in Jobtracker log while call heartbeat

Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amar Kamat updated HADOOP-4288:
-------------------------------

    Attachment: HADOOP-4288-v1.patch

Assuming that the NPE is because of the scenario I have mentioned above, uploading a straight forward fix. Testing in progress.

> java.lang.NullPointerException is observed in Jobtracker log while   call heartbeat
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4288
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>            Reporter: Karam Singh
>            Assignee: Amar Kamat
>            Priority: Blocker
>         Attachments: HADOOP-4288-v1.patch
>
>
> 2008-09-26 09:33:08,190 INFO org.apache.hadoop.ipc.Server: IPC Server handler 5 on 34441, call heartbeat(org.apache.hadoop.mapred.TaskTrackerStatus@177a878, false, true, 100) from <ipaddress:port>: error: java.io.IOException: java.lang.NullPointerException  
> is observed in Jobtracker log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.