You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/10/26 17:37:33 UTC
[kudu-CR] fs: ensure the existence of important directories on open
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8399
Change subject: fs: ensure the existence of important directories on open
......................................................................
fs: ensure the existence of important directories on open
Seems like a pretty easy way to improve robustness, especially for CLI tools
that may not access these directories directly but nevertheless want to
guarantee their existence before making destructive changes.
Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
---
M src/kudu/fs/fs_manager.cc
M src/kudu/tools/kudu-tool-test.cc
2 files changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/8399/1
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 23:04:48 +0000
Gerrit-HasComments: No
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 3: Verified+1
Overriding Jenkins, TSAN failure was due to the same old dist-test only TLS issue.
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 21:42:18 +0000
Gerrit-HasComments: No
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc@317
PS2, Line 317: Substitute("missing required directory $0", d));
nit: From `man 2 stat` this can fail for a variety of reasons (eg ENOTDIR, EBADF, EOVERFLOW, etc.). How about a more generalized error message? "could not verify required directory" or something?
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 20:57:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 21:00:07 +0000
Gerrit-HasComments: No
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8399
to look at the new patch set (#3).
Change subject: fs: ensure the existence of important directories on open
......................................................................
fs: ensure the existence of important directories on open
Seems like a pretty easy way to improve robustness, especially for CLI tools
that may not access these directories directly but nevertheless want to
guarantee their existence before making destructive changes.
Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 38 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/8399/3
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
fs: ensure the existence of important directories on open
Seems like a pretty easy way to improve robustness, especially for CLI tools
that may not access these directories directly but nevertheless want to
guarantee their existence before making destructive changes.
Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Reviewed-on: http://gerrit.cloudera.org:8080/8399
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 38 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Verified
Andrew Wong: Looks good to me, but someone else must approve
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc@317
PS2, Line 317: Substitute("could not verify required directory $0", d));
> nit: From `man 2 stat` this can fail for a variety of reasons (eg ENOTDIR,
Done
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 21:11:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 26 Oct 2017 21:48:27 +0000
Gerrit-HasComments: No
[kudu-CR] fs: ensure the existence of important directories on open
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8399
to look at the new patch set (#2).
Change subject: fs: ensure the existence of important directories on open
......................................................................
fs: ensure the existence of important directories on open
Seems like a pretty easy way to improve robustness, especially for CLI tools
that may not access these directories directly but nevertheless want to
guarantee their existence before making destructive changes.
Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 26 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/8399/2
--
To view, visit http://gerrit.cloudera.org:8080/8399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec
Gerrit-Change-Number: 8399
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>