You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/22 14:50:39 UTC

[GitHub] [pulsar] linlinnn opened a new pull request #10329: [pulsar-perf] Fix inaccurate throughput statistics

linlinnn opened a new pull request #10329:
URL: https://github.com/apache/pulsar/pull/10329


   Fixes #10324
   
   ### Motivation
   fix inaccurate throughput statistics


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn closed pull request #10329: [pulsar-perf] Fix inaccurate throughput statistics

Posted by GitBox <gi...@apache.org>.

linlinnn closed pull request #10329:
URL: https://github.com/apache/pulsar/pull/10329


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10329: [pulsar-perf] Fix inaccurate throughput statistics

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on a change in pull request #10329:
URL: https://github.com/apache/pulsar/pull/10329#discussion_r618515065



##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
##########
@@ -430,7 +430,7 @@ public static void main(String[] args) throws Exception {
 
             double rate = messagesSent.sumThenReset() / elapsed;
             double failureRate = messagesFailed.sumThenReset() / elapsed;
-            double throughput = bytesSent.sumThenReset() / elapsed / 1024 / 1024 * 8;

Review comment:
       It's Mbit here not Mbytes here, could you please double check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org