You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2017/07/11 23:40:25 UTC
[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule
Bikramjeet Vig has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7401
Change subject: IMPALA-5104: Fix Query Admission Rule
......................................................................
IMPALA-5104: Fix Query Admission Rule
This allows queries to be admitted with estimated or requested memory
equal to process memory limit.
Added corresponding test case.
Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
---
M be/src/scheduling/admission-controller.cc
M tests/custom_cluster/test_admission_controller.py
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7401/1
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5104: Fix Query Admission Rule
......................................................................
Patch Set 1:
(5 comments)
Looks pretty good, just some nits.
http://gerrit.cloudera.org:8080/#/c/7401/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Fix Query Admission Rule
Vague subject line, which is often the only thing shown (e.g. git log --oneline, etc.). Can you make this:
"Admit queries with mem equal to proc mem_limit"
http://gerrit.cloudera.org:8080/#/c/7401/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:
PS1, Line 323: PROC_MEM_TEST_LIMIT
move this constant to just above this method since it's only used here
PS1, Line 326: query
a query
PS1, Line 326: process
the process
PS1, Line 326: requested
the requested
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has uploaded a new patch set (#2).
Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit
......................................................................
IMPALA-5104: Admit queries with mem equal to proc mem_limit
This allows queries to be admitted with estimated or requested memory
equal to the process memory limit.
Added a corresponding test case.
Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
---
M be/src/scheduling/admission-controller.cc
M tests/custom_cluster/test_admission_controller.py
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/7401/2
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/853/
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit
......................................................................
IMPALA-5104: Admit queries with mem equal to proc mem_limit
This allows queries to be admitted with estimated or requested memory
equal to the process memory limit.
Added a corresponding test case.
Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Reviewed-on: http://gerrit.cloudera.org:8080/7401
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/scheduling/admission-controller.cc
M tests/custom_cluster/test_admission_controller.py
2 files changed, 17 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-5104: Fix Query Admission Rule
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7401/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Fix Query Admission Rule
> Vague subject line, which is often the only thing shown (e.g. git log --one
Done
http://gerrit.cloudera.org:8080/#/c/7401/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:
PS1, Line 323: PROC_MEM_TEST_LIMIT
> move this constant to just above this method since it's only used here
Done
PS1, Line 326: requested
> the requested
Done
PS1, Line 326: query
> a query
Done
PS1, Line 326: process
> the process
Done
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I197648f4162f2057141517b4b42ab5196884a65a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No