You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/04 19:32:27 UTC
Review Request 64312: Added reservation refinement documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64312/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Joerg Schad.
Bugs: MESOS-7663
https://issues.apache.org/jira/browse/MESOS-7663
Repository: mesos
Description
-------
See summary.
Diffs
-----
docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
docs/task-state-reasons.md 8cf0c53d07a4db49437f52c7d7f991f621d523ac
docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23
include/mesos/resource_provider/resource_provider.hpp 45cda4251af6c437841609fbf611108b2955422e
include/mesos/resource_provider/resource_provider.proto 2ce71f4c3e97e89c226966c347c2817e2bab9c1b
include/mesos/type_utils.hpp b786d0e1b887306e68561ce7c9907fa844d5786a
include/mesos/v1/mesos.hpp f393ed5654ad6d0b3eb5e28548c972779b082425
include/mesos/v1/resource_provider/resource_provider.hpp 3fc45c94df2678b2c3a778eb3b7acbbd0d0446b7
include/mesos/v1/resource_provider/resource_provider.proto 465b11dafd7c2e3b9476696ed75c1c077d6c8eeb
src/common/type_utils.cpp 1b466fcfd133b6fd0067668c7ba54d1ce80c8702
src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
src/resource_provider/validation.cpp 984d5934953c1f0a16a400fb2a2cc2cc5eb2ed89
src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01
src/v1/mesos.cpp 2c81b37468dc27da863eb8a56a213436b94b73de
Diff: https://reviews.apache.org/r/64312/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 64312: Added reservation refinement documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64312/#review193200
-----------------------------------------------------------
Fix it, then Ship it!
docs/reservation.md
Lines 104 (patched)
<https://reviews.apache.org/r/64312/#comment271747>
to both see and make refined reservations?
- Benjamin Mahler
On Dec. 4, 2017, 9:58 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64312/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 9:58 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Joerg Schad.
>
>
> Bugs: MESOS-7663
> https://issues.apache.org/jira/browse/MESOS-7663
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added reservation refinement documentation.
>
>
> Diffs
> -----
>
> docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
> docs/upgrades.md 7b77ef9a173ee8271979e40a2e15f653318e22c9
>
>
> Diff: https://reviews.apache.org/r/64312/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 64312: Added reservation refinement documentation.
Posted by Michael Park <mp...@apache.org>.
> On Dec. 4, 2017, 2:08 p.m., Benjamin Mahler wrote:
> > docs/upgrades.md
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/64312/diff/2/?file=1908346#file1908346line108>
> >
> > Hm.. I'm not sure we should mention this here, it's a bit confusing to metion an "internal Mesos c++ library" as part of the framework API? We could have a c++ public headers section but since we break it all the time and haven't been publishing the changes here I'd probably shy away from that.
Yeah, this was a specific request from Joerg because he was working with some people who are using our internal libraries and these changes broke them :(
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64312/#review192779
-----------------------------------------------------------
On Dec. 4, 2017, 1:58 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64312/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 1:58 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Joerg Schad.
>
>
> Bugs: MESOS-7663
> https://issues.apache.org/jira/browse/MESOS-7663
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added reservation refinement documentation.
>
>
> Diffs
> -----
>
> docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
> docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23
>
>
> Diff: https://reviews.apache.org/r/64312/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 64312: Added reservation refinement documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64312/#review192779
-----------------------------------------------------------
Fix it, then Ship it!
docs/reservation.md
Line 83 (original), 96 (patched)
<https://reviews.apache.org/r/64312/#comment271034>
Labeled reservation is now a sub-section of reservation refinement? Seems wrong? Should it be it's own top-level section?
docs/upgrades.md
Lines 108 (patched)
<https://reviews.apache.org/r/64312/#comment271033>
Hm.. I'm not sure we should mention this here, it's a bit confusing to metion an "internal Mesos c++ library" as part of the framework API? We could have a c++ public headers section but since we break it all the time and haven't been publishing the changes here I'd probably shy away from that.
- Benjamin Mahler
On Dec. 4, 2017, 9:58 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64312/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 9:58 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Joerg Schad.
>
>
> Bugs: MESOS-7663
> https://issues.apache.org/jira/browse/MESOS-7663
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added reservation refinement documentation.
>
>
> Diffs
> -----
>
> docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
> docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23
>
>
> Diff: https://reviews.apache.org/r/64312/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 64312: Added reservation refinement documentation.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64312/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 1:58 p.m.)
Review request for mesos, Benjamin Mahler and Joerg Schad.
Changes
-------
Rebased.
Bugs: MESOS-7663
https://issues.apache.org/jira/browse/MESOS-7663
Repository: mesos
Description (updated)
-------
Added reservation refinement documentation.
Diffs (updated)
-----
docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23
Diff: https://reviews.apache.org/r/64312/diff/2/
Changes: https://reviews.apache.org/r/64312/diff/1-2/
Testing
-------
Thanks,
Michael Park